public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/4] Test for CVE-2016-10044 mark AIO pseudo-fs noexec
Date: Tue, 18 Jul 2017 03:58:29 -0400 (EDT)	[thread overview]
Message-ID: <1513116395.54444036.1500364708984.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170718073319.23543-5-rpalethorpe@suse.com>


----- Original Message -----
...
> +
> +#include "tst_test.h"
> +
> +#ifdef HAVE_LINUX_AIO_ABI_H
> +
> +#include <stdio.h>
> +#include <string.h>
> +#include <linux_syscall_numbers.h>
> +#include <linux/aio_abi.h>

Hi,

from LTP docs:
"Don't use +linux/+ headers if at all possible. Usually they are replaced with
+sys/+ headers as things work their way into glibc.  Furthermore, +linux/+
headers get shuffled around a lot more than their +sys/+ counterparts it
seems."

If we really have to use linux header then I'd suggest a configure check
that also checks it's compilable.

Regards,
Jan

  reply	other threads:[~2017-07-18  7:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  7:33 [LTP] [PATCH 0/4] CVE-2016-10044 and SAFE_PERSONALITY Richard Palethorpe
2017-07-18  7:33 ` [LTP] [PATCH 1/4] configure.ac: Add check for aio_abi.h Richard Palethorpe
2017-07-18  7:33 ` [LTP] [PATCH 2/4] lib: Add personality fallback and SAFE macro Richard Palethorpe
2017-07-18  7:33 ` [LTP] [PATCH 3/4] CVE-2012-0957: Use SAFE_PERSONALITY Richard Palethorpe
2017-07-18  7:33 ` [LTP] [PATCH 4/4] Test for CVE-2016-10044 mark AIO pseudo-fs noexec Richard Palethorpe
2017-07-18  7:58   ` Jan Stancek [this message]
2017-07-18  9:09     ` Richard Palethorpe
2017-07-18 13:40       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513116395.54444036.1500364708984.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox