From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] pause01: rewrite testcase
Date: Thu, 12 May 2016 05:11:37 -0400 (EDT) [thread overview]
Message-ID: <1517175101.1991600.1463044297830.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160511132136.GE24701@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Wednesday, 11 May, 2016 3:21:36 PM
> Subject: Re: [LTP] [PATCH 2/2] pause01: rewrite testcase
> > -static void go(int sig)
> > -{
> > - (void)sig;
> > + /*
> > + * TST_CHECKPOINT_WAIT has built-in timeout, if pause() doesn't return,
> > + * this checkpoint call will reliably end the test.
> > + */
> > + TST_CHECKPOINT_WAIT(0);
> > + SAFE_WAIT(&status);
>
> Hmm, maybe it would be better if we add timeout logic to the new test
> library instead of adding it to selected few testcases.
I pushed it with all your suggestions, except for the timeout logic.
Did you have something specific in mind how to implement this?
My first thought was a new field to tst_test struct, and forking
a watchdog process.
Regards,
Jan
next prev parent reply other threads:[~2016-05-12 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 12:03 [LTP] [PATCH 1/2] checkpoints: avoid unnecesasry sleep in checkpoint_wake Jan Stancek
2016-05-11 12:03 ` [LTP] [PATCH 2/2] pause01: rewrite testcase Jan Stancek
2016-05-11 13:21 ` Cyril Hrubis
2016-05-12 9:11 ` Jan Stancek [this message]
2016-05-12 9:14 ` Cyril Hrubis
2016-05-11 12:23 ` [LTP] [PATCH 1/2] checkpoints: avoid unnecesasry sleep in checkpoint_wake Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517175101.1991600.1463044297830.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox