From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 3/4] ima/ima_boot_aggregate: Increase MAX_EVENT_SIZE to 8k
Date: Tue, 27 Mar 2018 15:44:15 -0400 [thread overview]
Message-ID: <1522179855.3541.191.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180314155731.5943-4-pvorel@suse.cz>
[Cc'ing George Wilson]
On Wed, 2018-03-14 at 16:57 +0100, Petr Vorel wrote:
> This is needed as according IMA developers there are BIOS events larger
> than 4k [1]. Actual size for TPM 1.2 is undefined, TPM 2.0 specifies:
> "For software parsing the event log, the parser can choose an arbitrary
> maximum size, but this specification recommends a maximum value for the
> TCG_PCR_EVENT2.eventSize field of 1MB." [2].
>
> So hope 8k is enough.
Is there a way of making this value system dependent? Â On my
laptop this is fine, but for PowerVM w/TPM 1.2 I've been told this is
too small.
> [1] http://lists.linux.it/pipermail/ltp/2018-January/006970.html
> [2] http://lists.linux.it/pipermail/ltp/2018-January/007002.html
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> ---
> testcases/kernel/security/integrity/ima/src/ima_boot_aggregate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/security/integrity/ima/src/ima_boot_aggregate.c b/testcases/kernel/security/integrity/ima/src/ima_boot_aggregate.c
> index f7ae77cb1..c52cea4c9 100644
> --- a/testcases/kernel/security/integrity/ima/src/ima_boot_aggregate.c
> +++ b/testcases/kernel/security/integrity/ima/src/ima_boot_aggregate.c
> @@ -30,7 +30,7 @@ char *TCID = "ima_boot_aggregate";
> #if HAVE_LIBCRYPTO
> #include <openssl/sha.h>
>
> -#define MAX_EVENT_SIZE 500
> +#define MAX_EVENT_SIZE 8192
> #define EVENT_HEADER_SIZE 32
> #define MAX_EVENT_DATA_SIZE (MAX_EVENT_SIZE - EVENT_HEADER_SIZE)
> #define NUM_PCRS 8 /* PCR registers 0-7 in boot aggregate */
next prev parent reply other threads:[~2018-03-27 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 15:57 [LTP] [RFC PATCH v2 0/4] Rewrite tests into new API + fixes Petr Vorel
2018-03-14 15:57 ` [LTP] [RFC PATCH v2 1/4] security/ima: " Petr Vorel
2018-03-14 16:32 ` Petr Vorel
2018-03-27 19:12 ` Mimi Zohar
2018-03-29 8:59 ` Petr Vorel
2018-04-10 15:56 ` Mimi Zohar
2018-04-11 19:03 ` Petr Vorel
2018-04-11 20:03 ` Mimi Zohar
2018-03-14 15:57 ` [LTP] [RFC PATCH v2 2/4] security/ima: Run measurements after policy Petr Vorel
2018-03-14 15:57 ` [LTP] [RFC PATCH v2 3/4] ima/ima_boot_aggregate: Increase MAX_EVENT_SIZE to 8k Petr Vorel
2018-03-27 19:44 ` Mimi Zohar [this message]
2018-03-27 22:23 ` George Wilson
2018-03-29 6:18 ` Petr Vorel
2018-03-14 15:57 ` [LTP] [RFC PATCH v2 4/4] ima/tpm: Various fixes Petr Vorel
2018-03-26 22:31 ` [LTP] [RFC PATCH v2 0/4] Rewrite tests into new API + fixes Mimi Zohar
2018-03-27 9:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522179855.3541.191.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox