From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Move getcwd05 to realpath01 and fix for old distro
Date: Thu, 2 Aug 2018 06:53:44 -0400 (EDT) [thread overview]
Message-ID: <1535534013.37569108.1533207223994.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180801134717.29909-1-mmoese@suse.de>
----- Original Message -----
> The testcase getcwd05 is a regression test for cve-2018-1000001 [1].
> However, there were changes in the behavior of libc functions, that some
> older
> distributions refused to backport.
> The testcase was two testcases, one for getcwd() and one for realpath().
> While the behavior of getcwd() changed, it is totally independent from
> the thestcase for the vulnerability in realpath. So, this test should be
> moved to realpath/realpath01.c. In addition, the test of getcwd() is
> totally unneeded here to test realpath() for the fix.
>
> [1]
> https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=52a713fdd0a30e1bd79818e2e3c4ab44ddca1a94
>
> Signed-off-by: Michael Moese <mmoese@suse.de>
Looks good to me, ack.
Adding Petr, as he wrote the original test.
Regards,
Jan
next prev parent reply other threads:[~2018-08-02 10:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 13:47 [LTP] [PATCH] Move getcwd05 to realpath01 and fix for old distro Michael Moese
2018-08-02 10:53 ` Jan Stancek [this message]
2018-08-13 13:41 ` Petr Vorel
2018-08-13 14:26 ` Cyril Hrubis
2018-08-14 7:13 ` Petr Vorel
2018-08-14 14:17 ` Cyril Hrubis
2018-08-14 15:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535534013.37569108.1533207223994.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox