Re: [LTP] [PATCH] Set tunable value of min_free_kbytes lower

[Zhouping Liu <zliu@redhat.com>]

----- Original Message -----
> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> To: "ZhouPing Liu" <zliu@redhat.com>
> Cc: "Shuang Qiu" <shuang.qiu@oracle.com>, ltp-list@lists.sourceforge.net
> Sent: Wednesday, August 29, 2012 4:29:52 PM
> Subject: Re: [LTP] [PATCH] Set tunable value of min_free_kbytes lower
> 
> 
> > yes, you are right.
> > I tried to fork several processes to hog memory, but I don't think
> > it's
> > a better way, so a good solution(I think) is included in below
> > patch.
> > 
> >>
> >> And we can also patch the overflow issue which I mentioned before:
> >>
> >> The type of total_mem "unsigned long" is not suitable with
> >> nowadays
> >> memory ,it will overflow(with i386) in line 177:map_count =
> >> total_mem
> >> *
> >> KB / MAP_SIZE and the value of map_count is not correct.
> >> Using "unsigned long long" could fix this issue.
> > 
> > after re-check the code, I found map_count was not necessary, so I
> > removed it,
> > at the same time, it fixed your the overflow issue.
> > 
> > please review the patch again, if you agree the fix, I will send a
> > formal patch set in new subject:
> 
> 
> So, please, thank you.

will do later, thanks for care :)

-- 
Thanks,
Zhouping

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list