From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] fanotify06: create a mount for test
Date: Fri, 1 Jul 2016 07:16:04 -0400 (EDT) [thread overview]
Message-ID: <1567220971.1417138.1467371764182.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160629195040.GA16831@quack2.suse.cz>
----- Original Message -----
> From: "Jan Kara" <jack@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it, jack@suse.cz
> Sent: Wednesday, 29 June, 2016 9:50:40 PM
> Subject: Re: [PATCH] fanotify06: create a mount for test
>
> On Wed 29-06-16 10:49:11, Jan Stancek wrote:
> > This testcase can rarely fail, when there is a background process
> > modifying files on same mountpoint as is LTP's tmpdir:
> >
> > fanotify06 1 TFAIL : fanotify06.c:212: group 0 got more than one
> > event (48 > 24)
> > fanotify06 2 TFAIL : fanotify06.c:212: group 1 got more than one
> > event (48 > 24)
> > fanotify06 3 TFAIL : fanotify06.c:212: group 2 got more than one
> > event (48 > 24)
> > fanotify06 4 TFAIL : fanotify06.c:222: group 3 got event
> > fanotify06 5 TFAIL : fanotify06.c:222: group 4 got event
> > fanotify06 6 TPASS : group 5 got no event
> > fanotify06 7 TPASS : group 6 got no event
> > fanotify06 8 TPASS : group 7 got no event
> > fanotify06 9 TPASS : group 8 got no event
> >
> > This patch creates a mount, which should be only used by this
> > test to limit interference from rest of OS. It also adds missing
> > tst_require_root().
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
> Yeah, that is a good idea. The patch looks good to me so feel free to add:
>
> Acked-by: Jan Kara <jack@suse.cz>
>
> Honza
Pushed.
Regards,
Jan
prev parent reply other threads:[~2016-07-01 11:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 8:49 [LTP] [PATCH] fanotify06: create a mount for test Jan Stancek
2016-06-29 10:14 ` Li Wang
2016-06-29 11:03 ` Jan Stancek
2016-06-29 19:50 ` Jan Kara
2016-07-01 11:16 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567220971.1417138.1467371764182.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox