From: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Use LTP_TIMEOUT_MUL in TST_RETRY_FN()
Date: Wed, 11 Sep 2019 11:17:57 +0200 [thread overview]
Message-ID: <1568193477.3738.3.camel@suse.de> (raw)
In-Reply-To: <20190911091242.GA24623@dell5510>
On Wed, 2019-09-11 at 11:12 +0200, Petr Vorel wrote:
> Hi Clemens,
>
> > We discovered timeout problems for well known candidates.
> > Most of the time we already use LTP_TIMEOUT_MUL in other cases to
> > globally increase timeout value. So doing it for this function as
> > well.
> > Signed-off-by: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
> > ---
> > testcases/lib/tst_test.sh | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> > diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> > index e0b24c6b9..80b8871cb 100644
> > --- a/testcases/lib/tst_test.sh
> > +++ b/testcases/lib/tst_test.sh
> > @@ -162,9 +162,11 @@ EXPECT_FAIL()
> > TST_RETRY_FN_EXP_BACKOFF()
> > {
> > + LTP_TIMEOUT_MUL=${LTP_TIMEOUT_MUL:-1}
> > +
> > local tst_fun="$1"
> > local tst_exp=$2
> > - local tst_sec=$(expr $3 \* 1000000)
> > + local tst_sec=$(expr $3 \* 1000000 \* $LTP_TIMEOUT_MUL)
> > local tst_delay=1
>
> I'm for it, but that will diverge from C API. Shouldn't we add it
> also
> to tst_common.h?
Agree, let me add it. Thx for the hint.
>
> Kind regards,
> Petr
next prev parent reply other threads:[~2019-09-11 9:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 8:55 [LTP] [PATCH] Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Clemens Famulla-Conrad
2019-09-11 9:12 ` Petr Vorel
2019-09-11 9:17 ` Clemens Famulla-Conrad [this message]
2019-09-11 16:52 ` [LTP] [PATCH v2 1/3] tst_test.sh: " Clemens Famulla-Conrad
2019-09-11 16:52 ` [LTP] [PATCH v2 2/3] tst_test.c: Add tst_adjust_timeout() Clemens Famulla-Conrad
2019-09-11 16:52 ` [LTP] [PATCH v2 3/3] tst_common.h: Use tst_adjust_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-09-12 5:42 ` [LTP] [PATCH v2 1/3] tst_test.sh: Use LTP_TIMEOUT_MUL " Li Wang
2019-09-12 8:52 ` Clemens Famulla-Conrad
2019-09-12 14:55 ` Petr Vorel
2019-09-12 16:49 ` Clemens Famulla-Conrad
2019-09-12 19:46 ` Clemens Famulla-Conrad
2019-09-12 21:51 ` Petr Vorel
2019-10-11 12:02 ` Petr Vorel
2019-10-11 12:53 ` Cyril Hrubis
2019-10-12 2:46 ` Li Wang
2019-10-16 11:25 ` Clemens Famulla-Conrad
2019-10-16 16:15 ` [LTP] [PATCH v3 1/4] " Clemens Famulla-Conrad
2019-10-16 16:15 ` [LTP] [PATCH v3 2/4] tst_test.c: Add tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-17 8:47 ` Petr Vorel
2019-10-16 16:15 ` [LTP] [PATCH v3 3/4] tst_common.h: Use tst_multiply_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-17 8:48 ` Petr Vorel
2019-10-16 16:15 ` [LTP] [PATCH v3 4/4] Add newlib shell test for tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-17 9:00 ` Petr Vorel
2019-10-17 8:39 ` [LTP] [PATCH v3 1/4] tst_test.sh: Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Petr Vorel
2019-10-17 12:23 ` Clemens Famulla-Conrad
2019-10-18 7:46 ` Petr Vorel
2019-10-18 8:29 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568193477.3738.3.camel@suse.de \
--to=cfamullaconrad@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox