From: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 0/3] shell: Introduce TST_TIMEOUT variable
Date: Fri, 20 Sep 2019 15:48:23 +0200 [thread overview]
Message-ID: <1568987303.3024.7.camel@suse.de> (raw)
In-Reply-To: <20190919135043.14359-1-pvorel@suse.cz>
Hi Petr,
On Thu, 2019-09-19 at 15:50 +0200, Petr Vorel wrote:
> Hi,
>
> changes v2->v3:
> * cast to int if awk is not available (Li) instead of TCONF
> * actually round variable (with 0.5) (Clemens)
> * fix variable description (Clemens)
Patchset looks good to me! Well done!
> * add 2 tests for TST_TIMEOUT (it'd be more useful to test
> LTP_TIMEOUT_MUL, but I'd wait for Christian's shell test
> patch [1] being merged)
lets place them in `lib/newlib_tests/shell/testcases` as Christian is
doing and add the `# output: ` tag so it might work then.
Or lets place them in a separate Patchset which we can merge after [1].
> [1] https://patchwork.ozlabs.org/patch/1151766/
next prev parent reply other threads:[~2019-09-20 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 13:50 [LTP] [PATCH v3 0/3] shell: Introduce TST_TIMEOUT variable Petr Vorel
2019-09-19 13:50 ` [LTP] [PATCH v3 1/3] shell: Add tst_is_num() Petr Vorel
2019-09-19 13:50 ` [LTP] [PATCH v3 2/3] shell: Introduce TST_TIMEOUT variable, add checks Petr Vorel
2019-09-24 14:07 ` Cyril Hrubis
2019-09-24 16:20 ` Petr Vorel
2019-09-24 18:38 ` Petr Vorel
2019-09-19 13:50 ` [LTP] [PATCH v3 3/3] net/if-mtu-change.sh: set TST_TIMEOUT Petr Vorel
2019-09-20 13:48 ` Clemens Famulla-Conrad [this message]
2019-09-24 7:01 ` [LTP] [PATCH v3 0/3] shell: Introduce TST_TIMEOUT variable Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568987303.3024.7.camel@suse.de \
--to=cfamullaconrad@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox