public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Steve Muckle <smuckle@google.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] include/mk/env_post.mk: enable __ANDROID__ definition for Android build
Date: Wed, 24 Apr 2019 12:27:32 -0700	[thread overview]
Message-ID: <15aeaa52-eecc-e21a-eb86-d66cfe81928e@google.com> (raw)
In-Reply-To: <1556124939-7699-1-git-send-email-ruanzw@xiaopeng.com>

On 4/24/19 9:55 AM, Zhengwang Ruan wrote:
> The definition of __ANDROID__ has been widely used to compile android-specific
> things (i.e. busybox [1] [2], dnsmasq [3]), so we expected NDK to automatically
> pass it to help build LTP for android, but unfortunately it didn't (it is tested
> with android-ndk-r19c). Currently, we have to manually specify -D__ANDROID__ in
> configure step before launch 'make ANDROID=1' command, and this is suffering for
> those who don't have good knowledge of LTP, so it is necessary to enable it if
> built for android.

Hi Zhengwang I mentioned in the other thread but just to get it here 
also, __ANDROID__ seems to be defined for me by the NDK. Could you try 
the steps Sandeep shared?

thanks,
steve

  reply	other threads:[~2019-04-24 19:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 16:55 [LTP] [PATCH v2] include/mk/env_post.mk: enable __ANDROID__ definition for Android build Zhengwang Ruan
2019-04-24 19:27 ` Steve Muckle [this message]
2019-04-24 21:11   ` Petr Vorel
2019-04-25  3:13   ` =?unknown-8bit?b?6Ziu5q2j5pe6?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15aeaa52-eecc-e21a-eb86-d66cfe81928e@google.com \
    --to=smuckle@google.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox