[LTP] [PATCH] dup3/dup3_02.c: fix O_CLOEXEC undeclared

[LTP] [PATCH] dup3/dup3_02.c: fix O_CLOEXEC undeclared

[zenglg.jy]

O_CLOEXEC is not defined in RHEL5. When execute make,
"dup3_02.c:55: error: ‘O_CLOEXEC’ undeclared here (not in a function)"
will be outputed.

Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
---
 testcases/kernel/syscalls/dup3/dup3_02.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/testcases/kernel/syscalls/dup3/dup3_02.c b/testcases/kernel/syscalls/dup3/dup3_02.c
index 0401ddc..9d5ef15 100644
--- a/testcases/kernel/syscalls/dup3/dup3_02.c
+++ b/testcases/kernel/syscalls/dup3/dup3_02.c
@@ -37,6 +37,9 @@
 #include "safe_macros.h"
 #include "linux_syscall_numbers.h"
 
+#ifndef O_CLOEXEC
+# define O_CLOEXEC 02000000
+#endif
 
 static void setup(void);
 static void cleanup(void);
-- 
1.8.2.1




------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] dup3/dup3_02.c: fix O_CLOEXEC undeclared

[Jan Stancek]

----- Original Message -----
> From: "zenglg.jy" <zenglg.jy@cn.fujitsu.com>
> To: "ltp-list" <ltp-list@lists.sourceforge.net>
> Sent: Friday, 3 January, 2014 11:49:03 AM
> Subject: [LTP] [PATCH] dup3/dup3_02.c: fix O_CLOEXEC undeclared
> 
> O_CLOEXEC is not defined in RHEL5. When execute make,
> "dup3_02.c:55: error: ‘O_CLOEXEC’ undeclared here (not in a function)"
> will be outputed.
> 
> Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>

I overlooked this email and sent identical patch today:

Reviewed-by: Jan Stancek <jstancek@redhat.com>


> ---
>  testcases/kernel/syscalls/dup3/dup3_02.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/dup3/dup3_02.c
> b/testcases/kernel/syscalls/dup3/dup3_02.c
> index 0401ddc..9d5ef15 100644
> --- a/testcases/kernel/syscalls/dup3/dup3_02.c
> +++ b/testcases/kernel/syscalls/dup3/dup3_02.c
> @@ -37,6 +37,9 @@
>  #include "safe_macros.h"
>  #include "linux_syscall_numbers.h"
>  
> +#ifndef O_CLOEXEC
> +# define O_CLOEXEC 02000000
> +#endif
>  
>  static void setup(void);
>  static void cleanup(void);
> --
> 1.8.2.1
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] dup3/dup3_02.c: fix O_CLOEXEC undeclared

[chrubis]

Hi!
> O_CLOEXEC is not defined in RHEL5. When execute make,
> "dup3_02.c:55: error: ???O_CLOEXEC??? undeclared here (not in a function)"
> will be outputed.
> 
> Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>

I've pushed a sligtly different patch that moves all the O_CLOEXEC
definitions that were scattered around the sources into lapi/fcntl.h
header. Thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list