public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: jack@suse.cz
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP] fanotify06 always failed on RHEL7
Date: Tue, 20 Jan 2015 03:57:29 -0500 (EST)	[thread overview]
Message-ID: <1679086070.9165707.1421744249957.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <671699407.9161653.1421743558663.JavaMail.zimbra@redhat.com>

Hi Jack & all,

fanotify06 always failed on RHEL7-GA as below. When I make some change of the codes flow, Test Pass All. 
Could you take a look at my unsure patch?

<<<test_start>>>
tag=fanotify06 stime=1421726003
cmdline="fanotify06"
contacts=""
analysis=exit
<<<test_output>>>
fanotify06    1  TPASS  :  group 0 get event: mask 2 pid=14922 fd=15
fanotify06    2  TPASS  :  group 1 get event: mask 2 pid=14922 fd=15
fanotify06    3  TPASS  :  group 2 get event: mask 2 pid=14922 fd=15
fanotify06    4  TFAIL  :  fanotify06.c:217: group 3 got event
fanotify06    5  TFAIL  :  fanotify06.c:217: group 4 got event
fanotify06    6  TFAIL  :  fanotify06.c:217: group 5 got event
fanotify06    7  TPASS  :  group 6 got no event
fanotify06    8  TPASS  :  group 7 got no event
fanotify06    9  TPASS  :  group 8 got no event

---------
diff --git a/testcases/kernel/syscalls/fanotify/fanotify06.c b/testcases/kernel/syscalls/fanot
index 8dcd68a..63519f6 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify06.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify06.c
@@ -93,7 +93,8 @@ static void create_fanotify_groups(void)
                                                 "fanotify_init failed");
                                }
                        }
-                       /* Add mount mark for each group */
+                       /* Add mount mark for group with lower priority */
+                       if (p == 0) {
                        ret = fanotify_mark(fd_notify[p][i],
                                            FAN_MARK_ADD | FAN_MARK_MOUNT,
                                            FAN_MODIFY,
@@ -104,9 +105,9 @@ static void create_fanotify_groups(void)
                                         "FAN_MARK_MOUNT, FAN_MODIFY, AT_FDCWD,"
                                         " '.') failed", fd_notify[p][i]);
                        }
+                       continue;
+                       }
                        /* Add ignore mark for groups with higher priority */
-                       if (p == 0)
-                               continue;
                        ret = fanotify_mark(fd_notify[p][i],
                                            FAN_MARK_ADD |
                                            FAN_MARK_IGNORED_MASK |


-- 
Regards, 
Li Wang 
Email: liwang@redhat.com 


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

       reply	other threads:[~2015-01-20  8:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <671699407.9161653.1421743558663.JavaMail.zimbra@redhat.com>
2015-01-20  8:57 ` Li Wang [this message]
2015-01-20  9:29   ` [LTP] fanotify06 always failed on RHEL7 Jan Kara
2015-01-20 10:05     ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1679086070.9165707.1421744249957.JavaMail.zimbra@redhat.com \
    --to=liwang@redhat.com \
    --cc=jack@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox