public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH V4] getrlimit03: adjust a bit of code to compatiable with mips32
Date: Tue, 16 Jul 2019 03:07:07 -0400 (EDT)	[thread overview]
Message-ID: <1694827109.292834.1563260827076.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1563185037-236824-2-git-send-email-hongzhi.song@windriver.com>



----- Original Message -----
> Error info:
> getrlimit03.c:104: FAIL: __NR_prlimit64(0) had rlim_cur =
> ffffffffffffffff but __NR_getrlimit(0) had rlim_cur = 7fffffff
> 
> According to kernel code: [arch/mips/include/uapi/asm/resource.h]
> RLIM_INFINITY is set to 0x7fffffffUL instead of ULONG_MAX on mips32.
> 
>  /*
>  * SuS says limits have to be unsigned.
>  * Which makes a ton more sense anyway,
>  * but we keep the old value on MIPS32,
>  * for compatibility:
>  */
>  #ifndef __mips64
>  # define RLIM_INFINITY      0x7fffffffUL
>  #endif
> 
> Adding conditional statement about mips to fix this.
> 
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> ---
>  testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> index e4d56c4..03bd821 100644
> --- a/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> +++ b/testcases/kernel/syscalls/getrlimit/getrlimit03.c
> @@ -26,6 +26,7 @@
>  
>  #include "tst_test.h"
>  #include "lapi/syscalls.h"
> +#include "lapi/abisize.h"
>  
>  /**
>   * Linux provides an "old" getrlimit syscall handler that uses signed long,
> @@ -61,7 +62,12 @@ struct rlimit_ulong {
>  	unsigned long rlim_cur;
>  	unsigned long rlim_max;
>  };
> -const unsigned long RLIM_INFINITY_UL = ULONG_MAX;
> +
> +#if defined(__mips) && defined(TST_ABI32)

I see several tests already use __mips__, why did you go with __mips here?
Anyway, I'm fine with the patch.

> +	const unsigned long RLIM_INFINITY_UL = 0x7fffffffUL;
> +#else
> +	const unsigned long RLIM_INFINITY_UL = ULONG_MAX;
> +#endif
>  
>  static int getrlimit_ulong(int resource, struct rlimit_ulong *rlim)
>  {
> --
> 2.8.1
> 
> 

  reply	other threads:[~2019-07-16  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-15 10:03 [LTP] [PATCH V4] getrlimit03: adjust a bit of code to compatiable with mips32 Hongzhi.Song
2019-07-15 10:03 ` Hongzhi.Song
2019-07-16  7:07   ` Jan Stancek [this message]
2019-07-16  9:07     ` Hongzhi, Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1694827109.292834.1563260827076.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox