From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] syscalls/ioctl_loop05: Use correct blockdev to get logical_block_size
Date: Wed, 24 Jun 2020 09:06:12 -0400 (EDT) [thread overview]
Message-ID: <1699837077.18529566.1593003972656.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200624113217.GC30917@yuki.lan>
----- Original Message -----
> Looking at what that command does it's not that complex. It does
> statfs() to get minor and major number, then scans /proc/self/mountinfo
> for these, since these are on third column and then just prints whatever
> it's in the 10th column. This isn't more complex that what we have here
> and avoids needs to execute binaries and parse the output.
Thanks for mountinfo pointer. We went down the stat() route already,
but hit issues with some filesystems. I tried it now with mountinfo
approach and that does seem to fix btrfs case too, so I agree that
parsing /proc/self/mountinfo rather than df output is nicer.
next prev parent reply other threads:[~2020-06-24 13:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 8:33 [LTP] [PATCH] syscalls/ioctl_loop05: Get the logic_block_size dynamically Yang Xu
2020-06-09 9:24 ` Jan Stancek
2020-06-09 9:48 ` Yang Xu
2020-06-09 10:16 ` Jan Stancek
2020-06-09 10:46 ` Yang Xu
2020-06-09 11:01 ` Jan Stancek
2020-06-10 1:19 ` Yang Xu
2020-06-10 5:37 ` [LTP] [PATCH v2] syscalls/ioctl_loop05: Use correct blockdev to get logical_block_size Yang Xu
2020-06-10 10:13 ` Jan Stancek
2020-06-10 10:42 ` Yang Xu
2020-06-10 12:19 ` Yang Xu
2020-06-10 13:04 ` Jan Stancek
2020-06-11 4:56 ` Yang Xu
2020-06-11 5:32 ` [LTP] [PATCH v3] " Yang Xu
2020-06-11 11:09 ` Jan Stancek
2020-06-12 2:57 ` Yang Xu
2020-06-24 5:07 ` Yang Xu
2020-06-24 11:32 ` Cyril Hrubis
2020-06-24 13:06 ` Jan Stancek [this message]
2020-06-25 17:10 ` Yang Xu
2020-06-28 7:42 ` [LTP] [PATCH v4 1/2] tst_device: Add new api tst_find_backing_dev(path, dev) Yang Xu
2020-06-28 7:42 ` [LTP] [PATCH v4 2/2] syscalls/ioctl_loop05: Use correct blockdev to get logical_block_size Yang Xu
2020-06-29 7:56 ` [LTP] [PATCH v4 1/2] tst_device: Add new api tst_find_backing_dev(path, dev) Jan Stancek
2020-06-29 10:37 ` Yang Xu
2020-06-29 11:08 ` Jan Stancek
2020-06-29 11:41 ` [LTP] [PATCH v5 " Yang Xu
2020-06-29 11:41 ` [LTP] [PATCH v5 2/2] syscalls/ioctl_loop05: Use correct blockdev to get logical_block_size Yang Xu
2020-07-02 9:18 ` [LTP] [PATCH v5 1/2] tst_device: Add new api tst_find_backing_dev(path, dev) Jan Stancek
2020-07-02 12:27 ` Cyril Hrubis
2020-07-02 13:17 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1699837077.18529566.1593003972656.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox