From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] Test library API changes
Date: Tue, 5 Apr 2016 11:06:40 -0400 (EDT) [thread overview]
Message-ID: <1715701236.19051634.1459868800247.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160405141627.GA21660@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Tuesday, 5 April, 2016 4:16:28 PM
> Subject: Re: [LTP] Test library API changes
>
> Hi!
> > > Or do you have a better idea how to proceed?
> >
> > I don't think I have. I was thinking about macros to generate
> > both prototypes, but that would probably get messy soon.
> >
> > One related idea I had for more "visual separation", was to
> > create subdir, e.g. include/oldlib and move all oldlib exclusive
> > headers there. And then add that dir to include dirs in CFLAGS,
> > so nothing changes for tests.
> >
> > Then (if I get the big picture), we could tell: "if you're looking
> > for a function for your newlib test, just avoid _fn headers
> > and anything in oldlib subdir". And same would apply for adding new
> > functions to newlib.
> >
> > What I image people do to discover these functions is search in
> > ltp/include,
> > and I'm guessing they'll get up to 3 hits: old header (which may or may not
> > have old_ in name), _fn header and tst_ header.
> >
> > This is what made me think if we can somehow steer them to look
> > at newlib headers first.
>
> I've added a patch on the top of the one that adds the new library that
> moves the old headers to include/old. Now only config.h, tst_* headers
> and safe_*fn.h are directly in include.
Thanks, include dir looks more tidy to me now.
I don't have any other ideas / comments / questions. I went mostly through
lib changes, I checked converted testcases only briefly.
Overall, I think we can merge it. I'd suggest to extend our usual
test/freeze time before release to make sure people have enough
time to try it.
Regards,
Jan
next prev parent reply other threads:[~2016-04-05 15:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 11:11 [LTP] Test library API changes Cyril Hrubis
2016-01-07 13:01 ` Jan Stancek
2016-01-07 13:27 ` Cyril Hrubis
2016-02-04 10:56 ` Cyril Hrubis
2016-02-08 18:02 ` Cyril Hrubis
2016-02-09 16:43 ` Cyril Hrubis
2016-02-09 16:57 ` Cyril Hrubis
2016-02-09 17:46 ` Cyril Hrubis
2016-02-10 10:42 ` Jan Stancek
2016-02-10 10:56 ` Cyril Hrubis
2016-02-10 11:41 ` Cyril Hrubis
2016-02-11 16:03 ` Cyril Hrubis
2016-02-12 12:33 ` Jan Stancek
2016-02-12 17:53 ` Cyril Hrubis
2016-02-16 21:19 ` Cyril Hrubis
2016-02-17 14:39 ` Jan Stancek
2016-02-17 15:54 ` Cyril Hrubis
2016-02-18 9:05 ` Jan Stancek
2016-02-18 11:07 ` Cyril Hrubis
2016-02-18 11:26 ` Jan Stancek
2016-02-18 11:53 ` Cyril Hrubis
2016-03-02 14:44 ` Cyril Hrubis
2016-03-03 13:13 ` Jan Stancek
2016-03-03 14:00 ` Cyril Hrubis
2016-03-10 16:57 ` Cyril Hrubis
2016-03-11 13:57 ` Jan Stancek
2016-03-14 12:51 ` Cyril Hrubis
2016-03-14 16:00 ` Cyril Hrubis
2016-03-15 8:58 ` Jan Stancek
2016-03-15 9:22 ` Cyril Hrubis
2016-03-17 16:06 ` Cyril Hrubis
2016-03-18 9:44 ` Jan Stancek
2016-03-31 10:01 ` Cyril Hrubis
2016-04-01 14:45 ` Jan Stancek
2016-04-04 12:04 ` Cyril Hrubis
2016-04-04 14:12 ` Jan Stancek
2016-04-05 14:16 ` Cyril Hrubis
2016-04-05 15:06 ` Jan Stancek [this message]
2016-04-06 10:37 ` Cyril Hrubis
2016-03-14 16:40 ` Cyril Hrubis
2016-02-18 9:14 ` Alexey Kodanev
2016-02-18 10:40 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715701236.19051634.1459868800247.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox