Re: [LTP] [PATCH] testcases/kernel/firmware: fix a bug of make install

Jan Stancek
2013-07-16T11:13:00Z

----- Original Message -----
> From: "alexey kodanev" <alexey.kodanev@oracle.com>
> To: "Peng Haitao" <penght@cn.fujitsu.com>
> Cc: "Jan Stancek" <jstancek@redhat.com>, ltp-list@lists.sourceforge.net
> Sent: Tuesday, 16 July, 2013 11:55:43 AM
> Subject: Re: [LTP] [PATCH] testcases/kernel/firmware: fix a bug of make install
>
> Hi!
>
> >>
> >> ifeq ($(SKIP),0)
> >> SUBDIRS += fw_load_kernel
> >> -SUBDIRS += fw_load_user
> >> endif
> >> +SUBDIRS += fw_load_user
> >>
> >> We always build userspace part. The check for kernel version is
> >> already in setup(). We just need to make sure userspace bits compile
> >> everywhere.
> >> I tried 2.6.32 based kernel, it builds and runs:
> >> # ./fw_load_user/fw_load
> >> fw_load 1 TCONF : Test must be run with kernel 3.7 or newer
> >> fw_load 2 TCONF : Remaining cases not appropriate for configuration
> >>
> or in case we don't want compile user-space part:

I think the issue here is that this testcase is listed in some runtest file (kernel_misc).
So when you try to run it, ltp is looking for 'fw_load' binary, which doesn't exist.

Regards,
Jan

> ...
>
> SUBDIRS += fw_load_user
> include $(top_srcdir)/include/mk/generic_trunk_target.mk
> else
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
> endif
>
> Thanks,
> Alexey