* [LTP] fanotify06 always failed on RHEL7
[not found] <671699407.9161653.1421743558663.JavaMail.zimbra@redhat.com>
@ 2015-01-20 8:57 ` Li Wang
2015-01-20 9:29 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2015-01-20 8:57 UTC (permalink / raw)
To: jack; +Cc: ltp-list
Hi Jack & all,
fanotify06 always failed on RHEL7-GA as below. When I make some change of the codes flow, Test Pass All.
Could you take a look at my unsure patch?
<<<test_start>>>
tag=fanotify06 stime=1421726003
cmdline="fanotify06"
contacts=""
analysis=exit
<<<test_output>>>
fanotify06 1 TPASS : group 0 get event: mask 2 pid=14922 fd=15
fanotify06 2 TPASS : group 1 get event: mask 2 pid=14922 fd=15
fanotify06 3 TPASS : group 2 get event: mask 2 pid=14922 fd=15
fanotify06 4 TFAIL : fanotify06.c:217: group 3 got event
fanotify06 5 TFAIL : fanotify06.c:217: group 4 got event
fanotify06 6 TFAIL : fanotify06.c:217: group 5 got event
fanotify06 7 TPASS : group 6 got no event
fanotify06 8 TPASS : group 7 got no event
fanotify06 9 TPASS : group 8 got no event
---------
diff --git a/testcases/kernel/syscalls/fanotify/fanotify06.c b/testcases/kernel/syscalls/fanot
index 8dcd68a..63519f6 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify06.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify06.c
@@ -93,7 +93,8 @@ static void create_fanotify_groups(void)
"fanotify_init failed");
}
}
- /* Add mount mark for each group */
+ /* Add mount mark for group with lower priority */
+ if (p == 0) {
ret = fanotify_mark(fd_notify[p][i],
FAN_MARK_ADD | FAN_MARK_MOUNT,
FAN_MODIFY,
@@ -104,9 +105,9 @@ static void create_fanotify_groups(void)
"FAN_MARK_MOUNT, FAN_MODIFY, AT_FDCWD,"
" '.') failed", fd_notify[p][i]);
}
+ continue;
+ }
/* Add ignore mark for groups with higher priority */
- if (p == 0)
- continue;
ret = fanotify_mark(fd_notify[p][i],
FAN_MARK_ADD |
FAN_MARK_IGNORED_MASK |
--
Regards,
Li Wang
Email: liwang@redhat.com
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] fanotify06 always failed on RHEL7
2015-01-20 8:57 ` [LTP] fanotify06 always failed on RHEL7 Li Wang
@ 2015-01-20 9:29 ` Jan Kara
2015-01-20 10:05 ` Li Wang
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2015-01-20 9:29 UTC (permalink / raw)
To: Li Wang; +Cc: ltp-list, jack
On Tue 20-01-15 03:57:29, Li Wang wrote:
> Hi Jack & all,
>
> fanotify06 always failed on RHEL7-GA as below. When I make some change of the codes flow, Test Pass All.
> Could you take a look at my unsure patch?
>
> <<<test_start>>>
> tag=fanotify06 stime=1421726003
> cmdline="fanotify06"
> contacts=""
> analysis=exit
> <<<test_output>>>
> fanotify06 1 TPASS : group 0 get event: mask 2 pid=14922 fd=15
> fanotify06 2 TPASS : group 1 get event: mask 2 pid=14922 fd=15
> fanotify06 3 TPASS : group 2 get event: mask 2 pid=14922 fd=15
> fanotify06 4 TFAIL : fanotify06.c:217: group 3 got event
> fanotify06 5 TFAIL : fanotify06.c:217: group 4 got event
> fanotify06 6 TFAIL : fanotify06.c:217: group 5 got event
> fanotify06 7 TPASS : group 6 got no event
> fanotify06 8 TPASS : group 7 got no event
> fanotify06 9 TPASS : group 8 got no event
Well, likely the reason is that you don't have commit
8edc6e1688fc8f02c8c1f53a2ec4928cb1055f4d in your kernel. The test is
correct as is.
Honza
>
> ---------
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify06.c b/testcases/kernel/syscalls/fanot
> index 8dcd68a..63519f6 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify06.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify06.c
> @@ -93,7 +93,8 @@ static void create_fanotify_groups(void)
> "fanotify_init failed");
> }
> }
> - /* Add mount mark for each group */
> + /* Add mount mark for group with lower priority */
> + if (p == 0) {
> ret = fanotify_mark(fd_notify[p][i],
> FAN_MARK_ADD | FAN_MARK_MOUNT,
> FAN_MODIFY,
> @@ -104,9 +105,9 @@ static void create_fanotify_groups(void)
> "FAN_MARK_MOUNT, FAN_MODIFY, AT_FDCWD,"
> " '.') failed", fd_notify[p][i]);
> }
> + continue;
> + }
> /* Add ignore mark for groups with higher priority */
> - if (p == 0)
> - continue;
> ret = fanotify_mark(fd_notify[p][i],
> FAN_MARK_ADD |
> FAN_MARK_IGNORED_MASK |
>
>
> --
> Regards,
> Li Wang
> Email: liwang@redhat.com
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] fanotify06 always failed on RHEL7
2015-01-20 9:29 ` Jan Kara
@ 2015-01-20 10:05 ` Li Wang
0 siblings, 0 replies; 3+ messages in thread
From: Li Wang @ 2015-01-20 10:05 UTC (permalink / raw)
To: Jan Kara; +Cc: ltp-list
----- Original Message -----
> On Tue 20-01-15 03:57:29, Li Wang wrote:
> > Hi Jack & all,
> >
> > fanotify06 always failed on RHEL7-GA as below. When I make some change of
> > the codes flow, Test Pass All.
> > Could you take a look at my unsure patch?
> >
> > <<<test_start>>>
> > tag=fanotify06 stime=1421726003
> > cmdline="fanotify06"
> > contacts=""
> > analysis=exit
> > <<<test_output>>>
> > fanotify06 1 TPASS : group 0 get event: mask 2 pid=14922 fd=15
> > fanotify06 2 TPASS : group 1 get event: mask 2 pid=14922 fd=15
> > fanotify06 3 TPASS : group 2 get event: mask 2 pid=14922 fd=15
> > fanotify06 4 TFAIL : fanotify06.c:217: group 3 got event
> > fanotify06 5 TFAIL : fanotify06.c:217: group 4 got event
> > fanotify06 6 TFAIL : fanotify06.c:217: group 5 got event
> > fanotify06 7 TPASS : group 6 got no event
> > fanotify06 8 TPASS : group 7 got no event
> > fanotify06 9 TPASS : group 8 got no event
> Well, likely the reason is that you don't have commit
> 8edc6e1688fc8f02c8c1f53a2ec4928cb1055f4d in your kernel. The test is
> correct as is.
Great! Thank you for your response promptly.
Li Wang
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-20 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <671699407.9161653.1421743558663.JavaMail.zimbra@redhat.com>
2015-01-20 8:57 ` [LTP] fanotify06 always failed on RHEL7 Li Wang
2015-01-20 9:29 ` Jan Kara
2015-01-20 10:05 ` Li Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox