[LTP] fanotify06 always failed on RHEL7

Li Wang
2015-01-20T08:57:38Z

Hi Jack & all,

fanotify06 always failed on RHEL7-GA as below. When I make some change of the codes flow, Test Pass All.
Could you take a look at my unsure patch?

<<<test_start>>>
tag=fanotify06 stime=1421726003
cmdline="fanotify06"
contacts=""
analysis=exit
<<<test_output>>>
fanotify06 1 TPASS : group 0 get event: mask 2 pid=14922 fd=15
fanotify06 2 TPASS : group 1 get event: mask 2 pid=14922 fd=15
fanotify06 3 TPASS : group 2 get event: mask 2 pid=14922 fd=15
fanotify06 4 TFAIL : fanotify06.c:217: group 3 got event
fanotify06 5 TFAIL : fanotify06.c:217: group 4 got event
fanotify06 6 TFAIL : fanotify06.c:217: group 5 got event
fanotify06 7 TPASS : group 6 got no event
fanotify06 8 TPASS : group 7 got no event
fanotify06 9 TPASS : group 8 got no event

---------
diff --git a/testcases/kernel/syscalls/fanotify/fanotify06.c b/testcases/kernel/syscalls/fanot
index 8dcd68a..63519f6 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify06.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify06.c
@@ -93,7 +93,8 @@ static void create_fanotify_groups(void)
"fanotify_init failed");
}
}
- /* Add mount mark for each group */
+ /* Add mount mark for group with lower priority */
+ if (p == 0) {
ret = fanotify_mark(fd_notify[p][i],
FAN_MARK_ADD | FAN_MARK_MOUNT,
FAN_MODIFY,
@@ -104,9 +105,9 @@ static void create_fanotify_groups(void)
"FAN_MARK_MOUNT, FAN_MODIFY, AT_FDCWD,"
" '.') failed", fd_notify[p][i]);
}
+ continue;
+ }
/* Add ignore mark for groups with higher priority */
- if (p == 0)
- continue;
ret = fanotify_mark(fd_notify[p][i],
FAN_MARK_ADD |
FAN_MARK_IGNORED_MASK |

--
Regards,
Li Wang
Email: liwang@redhat.com