Re: [LTP] [PATCH] syscalls/cma: add runtime check to setup()

chrubis
2013-04-23T12:44:11Z

Hi!
> > > static void setup(void)
> > > @@ -191,9 +191,11 @@ static void setup(void)
> > > sflag ? SAFE_STRTOL(NULL, sz_opt, 1, LONG_MAX - PADDING_SIZE * 2)
> > > : 100000;
> > >
> > > -#if !defined(__NR_process_vm_readv)
> > > +#if !defined(__NR_process_vm_writev)
> > > tst_brkm(TCONF, NULL, "process_vm_writev does not exist "
> > > "on your system");
> > > +#else
> > > + ltp_syscall(__NR_process_vm_writev, 0, NULL, 0, NULL, 0, 0);
> > > #endif
> > > semid = init_sem(1);
> >
> > If you add the __NR_process_vm_writev to at least one of the
> > testscases/kernel/include/*.in and run regen script (make clean && make
> > in the corresponding dir), the linux_syscall_numbers.h will contain at
> > least stubs and ltp_syscall() will be able to handle both situations.
>
> We seem to be regenerating linux_syscall_numbers.h only when it's missing
> or when you run it manually. Should we just remove it from git tree?
> Build process will generate one and it will contain latest bits from *.in files

Right. And please add dependency on the *.in files too (this seems to be
missing as well).

--
Cyril Hrubis
chrubis@suse.cz