Re: [LTP] [PATCH] syscalls/cma: add runtime check to setup()

chrubis
2013-04-24T15:57:21Z

Hi!
> > > delete all the "#else" branches since you're now using
> > > linux_syscall_numbers.h
> >
> > Without that check in parent, you can end up in situation where some child
> > aborts first and then parent reports failure. By doing it early in setup()
> > you can avoid allocating resources that won't go away when process later
> > terminates with TCONF.
>
> by including linux_syscall_numbers.h, you've guaranteed that
> __NR_process_vm_readv will always be defined, thus the code under "#ifndef
> __NR_process_vm_readv" will never be run, thus you should delete it.

Not until these are added to at least one of the in files and
linux_syscall_numbers.h are regenerated.

Which is why we started to fiddle with the kernel/include directory in
the first place.

--
Cyril Hrubis
chrubis@suse.cz