From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] selftests: vdso: hash entry size on alpha, s390x is 8 bytes
Date: Mon, 3 Aug 2020 08:18:22 -0400 (EDT) [thread overview]
Message-ID: <1881588710.5797015.1596457102422.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <9927ed18c642db002e43afe5e36fb9c18c4f9495.1594811090.git.jstancek@redhat.com>
----- Original Message -----
> parse_vdso.c is crashing on 5.8-rc5 s390x, because it wrongly reads
> nbucket as 0:
> Program received signal SIGFPE, Arithmetic exception.
> 0x0000000001000f3e in vdso_sym (version=0x1001280 "LINUX_2.6",
> name=0x100128a "__vdso_getcpu") at parse_vdso.c:207
> 207 ELF(Word) chain = vdso_info.bucket[elf_hash(name) %
> vdso_info.nbucket];
> (gdb) p vdso_info.nbucket
> $1 = 0
>
> Per readelf source:
> https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=binutils/readelf.c;h=2406304fe35a832ac53aa7b1a367f3f7afed4264;hb=HEAD#l10027
> and objdump output hash entries are double size on 64bit s390 and alpha:
> 0000000000000120 <.hash>:
> 120: 00 00 00 00 .long 0x00000000
> 124: 00 00 00 03 .long 0x00000003
> 128: 00 00 00 00 .long 0x00000000
> 12c: 00 00 00 07 .long 0x00000007
> 130: 00 00 00 00 .long 0x00000000
> 134: 00 00 00 01 .long 0x00000001
> 138: 00 00 00 00 .long 0x00000000
> 13c: 00 00 00 05 .long 0x00000005
> 140: 00 00 00 00 .long 0x00000000
> 144: 00 00 00 06 .long 0x00000006
> ...
> 16c: 00 00 00 02 .long 0x00000002
> 170: 00 00 00 00 .long 0x00000000
> 174: 00 00 00 03 .long 0x00000003
> 178: 00 00 00 00 .long 0x00000000
> 17c: 00 00 00 04 .long 0x00000004
>
> Do similar check in parse_vdso.c and treat hash entries as double word.
Ping, any thoughts about the issue or patch?
next prev parent reply other threads:[~2020-08-03 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 11:07 [LTP] [PATCH] selftests: vdso: hash entry size on alpha, s390x is 8 bytes Jan Stancek
2020-08-03 12:18 ` Jan Stancek [this message]
2020-08-03 12:34 ` Mark Brown
2020-08-05 12:53 ` Cyril Hrubis
2020-08-05 12:58 ` Jan Stancek
2020-08-07 11:23 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1881588710.5797015.1596457102422.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox