Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'

Jan Stancek
2013-03-15T09:12:04Z

> From: "Zhouping Liu" <zliu@redhat.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: chrubis@suse.cz, "LTP List" <ltp-list@lists.sourceforge.net>
> Sent: Friday, 15 March, 2013 3:52:26 AM
> Subject: Re: [LTP] [PATCH 3/5] mm/oom0[3|4]: added 'OOM for CPUSET' and updated 'OOM with MEMCG & numa'

> > We could add a simple function to numa_helper, but I'm not sure
> > what
> > it would return as default, some tests care about nodes with
> > memory.
>
> yes, what you care about is right, but now we only need a function,
> which
> can tell us the system have more than one node, we don't care about
> the
> nodes have
> CPUs or memory.

What I was wondering is why that comment said "rough estimate",
it looks quite accurate. Anyway, thanks for clarifying.

Regards,
Jan

>
> so I will created is_numa() in numa_helper to implement it.
>
> Thanks
> Zhouping