Re: [LTP] [PATCH 3/8] tst_test.c: Change check_kver() return type to bool

[Avinesh Kumar <akumar@suse.de>]

On Friday, November 7, 2025 11:29:34 AM CET Petr Vorel wrote:
> Also change the value (0 becomes true), add docs (don't use kerneldoc as
> this is a internal function which does not need to be in LTP online doc).
nit: 
s/a internal/an internal
(also applies in Patch 4)

> 
> While at it, add missing static.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/tst_test.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index bda66c4672..1725844b54 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -1056,7 +1056,12 @@ static void do_exit(int ret)
>  	exit(ret);
>  }
>  
> -int check_kver(const char *min_kver, const int brk_nosupp)
> +/*
> + * Check for the required kernel version.
> + *
> + * return: true if the kernel version is high enough, false otherwise.
> + */
> +static bool check_kver(const char *min_kver, const int brk_nosupp)
>  {
>  	char *msg;
>  	int v1, v2, v3;
> @@ -1075,10 +1080,10 @@ int check_kver(const char *min_kver, const int brk_nosupp)
>  		else
>  			tst_res(TCONF, msg, min_kver);
>  
> -		return 1;
> +		return false;
>  	}
>  
> -	return 0;
> +	return true;
>  }
>  
>  static int results_equal(struct results *a, struct results *b)
> @@ -1963,7 +1968,7 @@ static int run_tcase_on_fs(struct tst_fs *fs, const char *fs_type)
>  	if (fs->mkfs_ver && !tst_check_cmd(fs->mkfs_ver, 0))
>  		return TCONF;
>  
> -	if (fs->min_kver && check_kver(fs->min_kver, 0))
> +	if (fs->min_kver && !check_kver(fs->min_kver, 0))
>  		return TCONF;
>  
>  	prepare_device(fs);
> 





-- 
Mailing list info: https://lists.linux.it/listinfo/ltp