public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [RFC] Cleanup of tools/ directory
@ 2016-11-14 14:05 Cyril Hrubis
  2016-11-21  9:10 ` Jan Stancek
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2016-11-14 14:05 UTC (permalink / raw)
  To: ltp

Hi!
I've stumbled upon the tools/ directory and there is quite a lot of
broken code that is not really useful for anything.

The Makefile skips netpipe*, pounder21 and top-LTP directories. Apart
from automatic changes nobody touched the top-LTP and netpipe* code for
more than six years, so I would say that it's safe enough to remove
these. The pounder21 had some fixes that looks like somebody is using
that so I guess that we should keep it.

Then there are files that looks like they could be removed as well:

* STPfailure_report.pl - most likely no change since 2004, looks useless o me

* ltp_master, ltp_check, README, ltpoutput*
  - remnants of some automated framework that used ltprun script that
    used runalltests.sh script, I will remove these since there is no
    reason to keep them now

In short has anybody anything agains removal of netpipe*, top-LTP,
STPfailure_report.pl, ltp_master, ltp_check, README, and ltpoutput* from
the tools/ directory?

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [RFC] Cleanup of tools/ directory
  2016-11-14 14:05 [LTP] [RFC] Cleanup of tools/ directory Cyril Hrubis
@ 2016-11-21  9:10 ` Jan Stancek
  2016-11-21 11:21   ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2016-11-21  9:10 UTC (permalink / raw)
  To: ltp





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: ltp@lists.linux.it
> Sent: Monday, 14 November, 2016 3:05:04 PM
> Subject: [LTP] [RFC] Cleanup of tools/ directory
> 
> Hi!
> I've stumbled upon the tools/ directory and there is quite a lot of
> broken code that is not really useful for anything.
> 
> The Makefile skips netpipe*, pounder21 and top-LTP directories. Apart
> from automatic changes nobody touched the top-LTP and netpipe* code for
> more than six years, so I would say that it's safe enough to remove
> these. The pounder21 had some fixes that looks like somebody is using
> that so I guess that we should keep it.

I see pounder referenced occasionally in RH bugzilla reports, so
I'd keep it.

> 
> Then there are files that looks like they could be removed as well:
> 
> * STPfailure_report.pl - most likely no change since 2004, looks useless o me
> 
> * ltp_master, ltp_check, README, ltpoutput*
>   - remnants of some automated framework that used ltprun script that
>     used runalltests.sh script, I will remove these since there is no
>     reason to keep them now
> 
> In short has anybody anything agains removal of netpipe*, top-LTP,
> STPfailure_report.pl, ltp_master, ltp_check, README, and ltpoutput* from
> the tools/ directory?

My only hesitation was netpipe, which is referenced by couple scripts,
but looking at tools/Makefile comment and fact we are not building it for
so many years, I guess nobody will miss it.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [RFC] Cleanup of tools/ directory
  2016-11-21  9:10 ` Jan Stancek
@ 2016-11-21 11:21   ` Cyril Hrubis
  0 siblings, 0 replies; 3+ messages in thread
From: Cyril Hrubis @ 2016-11-21 11:21 UTC (permalink / raw)
  To: ltp

Hi!
Pushed with your ack, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-21 11:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14 14:05 [LTP] [RFC] Cleanup of tools/ directory Cyril Hrubis
2016-11-21  9:10 ` Jan Stancek
2016-11-21 11:21   ` Cyril Hrubis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox