public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/mmap17.c: Add new regression test
Date: Tue, 6 Feb 2018 14:53:14 -0500 (EST)	[thread overview]
Message-ID: <195340110.511328.1517946794955.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <5A794E19.3000201@cn.fujitsu.com>



----- Original Message -----
> > The patch you referenced is x86 specific, so we can restrict the test to
> > x86.
> > Also please set the minimum kernel version this is expected to fail on.
> 1) Before commit c64b04f, we couldn't read phys_addr_bits from
> /proc/cpuinfo in 32-bit kernel on x86.
> 2) On non-x86 architectures, we couldn't read phys_addr_bits from
> /proc/cpuinfo as well.
> 
> According to above reasons, i perfer to check phys_addr_bits in
> /proc/cpuinfo rather than the minimum
> kernel version and x86 architecture.   We can skip this test if
> phys_addr_bits isn't available.

I was referring to kernel patch. Does it make sense for this test
to run on older kernels? Based on description it might crash, so
presumably yes.

But do we also want to report FAIL on older kernels if mmap succeeds?
That does not violate any docs.

> addr[0] = 'a';
If mmap works, this has potential of triggering signal,
which will lead to TBROK.

Regards,
Jan

  reply	other threads:[~2018-02-06 19:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 10:03 [LTP] [PATCH] syscalls/mmap17.c: Add new regression test Xiao Yang
2018-02-02 10:20 ` Jan Stancek
2018-02-05 10:45   ` Xiao Yang
2018-02-05 11:42     ` Jan Stancek
2018-02-06  6:41       ` Xiao Yang
2018-02-06 19:53         ` Jan Stancek [this message]
2018-02-06 21:15           ` Jan Stancek
2018-02-07 12:05             ` Xiao Yang
2018-02-11 21:47               ` Jan Stancek
2018-02-14  7:34                 ` Xiao Yang
2018-02-22  7:32                 ` [LTP] [PATCH v3] " Xiao Yang
2018-04-04 14:31                   ` Cyril Hrubis
2019-04-16 10:42                     ` xuyang
2018-02-06  6:43       ` [LTP] [PATCH v2] " Xiao Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=195340110.511328.1517946794955.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox