From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] mmap16: extend checkpoint wait time during fs fill
Date: Mon, 13 Feb 2017 08:33:52 -0500 (EST) [thread overview]
Message-ID: <1957234398.3738860.1486992832599.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170213100234.GD16973@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Monday, 13 February, 2017 11:02:34 AM
> Subject: Re: [LTP] [PATCH] mmap16: extend checkpoint wait time during fs fill
>
> Hi!
> > +
> > + /* Give parent enough time to consume FS free blocks */
> > + if (tst_checkpoint_wait(0, 60*1000))
> > + tst_brkm(TBROK | TERRNO, cleanup,
> > + "wait for parent to fill entire space");
>
> Hrm, I wonder why I hardcoded the timeout into the library. It would be
> much better if we could have used the safe variant here.
>
> What about we add TST_SAFE_CHECKPOINT_WAIT2() that would take a timeout
> parameter. Pretty much the same as we do for WAKE2 that takes a number
> of processes to wake as a paramter.
Fine by me. Can you push it?
I can rebase & push patch using new TST_SAFE_CHECKPOINT_WAIT2().
Regards,
Jan
prev parent reply other threads:[~2017-02-13 13:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 13:38 [LTP] [PATCH] mmap16: extend checkpoint wait time during fs fill Jan Stancek
2017-02-13 10:02 ` Cyril Hrubis
2017-02-13 13:33 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1957234398.3738860.1486992832599.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox