From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/acct02: Check read size.
Date: Thu, 31 Oct 2019 04:53:09 -0400 (EDT) [thread overview]
Message-ID: <2003376860.9886044.1572511989903.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2dO95d2_CZyMpE4fM8CcC+p0ou9XfA43sS9fX0LmQBWoQ@mail.gmail.com>
----- Original Message -----
> > Above was RHEL7. Do you expect different outcome on RHEL8?
> > I was looking at upstream sources too and it looked similar.
> >
> > Anyway, I don't think this part is an issue, test will skip it
> > because "comm" doesn't match.
> >
> > We can tweak 'ac_btime' condition, but I think the test will remain
> >
>
> How much time of the ac_btime shaking to be tolerated is proper?
I wanted to go with 1 sec:
@@ -83,7 +83,7 @@ static int verify_acct(void *acc, int elap_time)
ret = 1;
}
- if (ACCT_MEMBER(ac_btime) < start_time) {
+ if (ACCT_MEMBER(ac_btime) + 1 < start_time) {
tst_res(TINFO, "ac_btime < %d (%d)", start_time,
ACCT_MEMBER(ac_btime));
ret = 1;
>
> > race-y in environments with higher steal time:
> >
>
> I'm sorry, what does it mean here?
I was referring to failed check below. s390 is scarce resource
and when over-committed, sleeps are less consistent.
E.g. sleep(1) taking 2+ seconds:
nanosleep({1, 0}, NULL) = 0 <1.926617>
>
>
>
> >
> > acct02.c:239: INFO: Verifying using 'struct acct_v3'
> > acct02.c:192: INFO: == entry 1 ==
> > acct02.c:127: INFO: elap_time/clock_ticks >= 2 (236/100: 2.00)
> > acct02.c:192: INFO: == entry 2 ==
> > acct02.c:82: INFO: ac_comm != 'acct02_helper' ('acct02')
> > acct02.c:127: INFO: elap_time/clock_ticks >= 2 (236/100: 2.00)
> > acct02.c:133: INFO: ac_exitcode != 32768 (0)
> > acct02.c:141: INFO: ac_ppid != 43213 (43212)
> > acct02.c:182: FAIL: end of file reached
next prev parent reply other threads:[~2019-10-31 8:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 9:47 [LTP] [PATCH] syscalls/acct02: Check read size Cyril Hrubis
2019-09-25 13:56 ` Petr Vorel
2019-09-25 16:14 ` Cyril Hrubis
2019-09-27 11:38 ` Cyril Hrubis
2019-09-27 12:48 ` Petr Vorel
2019-10-30 9:06 ` Jan Stancek
2019-10-30 13:03 ` Jan Stancek
2019-10-30 14:46 ` Petr Vorel
2019-10-30 17:41 ` Jan Stancek
2019-10-31 8:43 ` Li Wang
2019-10-31 8:53 ` Jan Stancek [this message]
2019-10-31 9:09 ` Petr Vorel
2019-11-01 6:03 ` Li Wang
2019-11-01 8:54 ` Jan Stancek
2019-10-31 9:06 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2003376860.9886044.1572511989903.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox