Re: [LTP] [RFC][PATCH] Add cpu architecrute check

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 846 bytes --]

On Thursday 04 June 2009 03:23:17 Nobuhiro Iwamatsu wrote:
> --- a/Makefile
> +++ b/Makefile
> +ifndef ARCH
> +# copy from Makefile in linux kernel
> +ARCH := $(shell uname -m

executing uname to detect build/target systems is never acceptable.

> --- a/testcases/kernel/syscalls/fallocate/Makefile
> +++ b/testcases/kernel/syscalls/fallocate/Makefile
> @@ -20,8 +20,14 @@
>  CFLAGS += -I../../../../include -Wall
>  LDLIBS += -L../../../../lib -lltp
>
> +# This system call is suported in i386, x86_64 and ppc only.
> +ifneq (,$(findstring $(ARCH), i386 x86_64 ppc))
>  SRCS    = $(wildcard *.c)
>  TARGETS = $(patsubst %.c,%,$(SRCS))
> +else
> +SRCS    =
> +TARGETS =
> +endif

atm, better to put the ifdef logic into the test itself.  look at some of the 
other tests that get stubbed out in the syscalls dir.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 408 bytes --]

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list