[LTP] [RFC] Using checkpatch.pl

[LTP] [RFC] Using checkpatch.pl

[Vijay Kumar]

Hi everyone,
Michal Simek patched most of the LTP code base to use the Linux kernel
coding style. But unfortunately new patches, that are flowing in, seem
to add coding style violations. It is better to prevent new style
violations than to fix them later on.

The kernel developers use a perl script called checkpatch.pl to
identify style violations in patches. We could use the same script to
check our patches, as well. The script uses files from the kernel to
do kernel specific checks. This can be disabled by using the --no-tree
option. So to check an LTP patch

$ checkpatch.pl --no-tree ltp-patch

If everybody is OK with it we can add the script to the LTP source
tree, so that everyone checks their patches against the same
script. And Subrata can easily check for style violations before
merging the patch.

In the future, we could also customize the script to do userspace/LTP
specific checks, like missing mode argument when open() is invoked
with O_CREAT flag.

Please do send in your suggestions.

Regards,
Vijay

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC] Using checkpatch.pl

[Garrett Cooper]

-----BEGIN PGP MESSAGE-----
Charset: ISO-8859-1
Version: GnuPG v2.0.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

hQIOA5OwxKigUnCpEAf+OF67wA6dR9skcNJZF15Z50C5w+e5lumGihLbP4lGx2W/
wckj4AkO9/qMhDPfou7flJD4jNQ+DQtpmtn+aCXdlwxOlhRAzyD9heG463uuSg9T
QeVhXrJWATEakJ20E3RujSjKFt+d83tVghhgOSwSifI8Tu62jLGF7b2CXOCgpwPm
D1BOUMhnVL/iaKTVpBtK881hml2iDio7L0LTyHF1VfH6mltClx8BELjK5ECmwODF
Hg3gstM1QGoCPZ22lLhjMKgG5WWw1t1puj5lf5z7Ubfz1fD0YadXwgSUOpbJCXqs
8bPrdEfUnNe1V+3NrgW/saSXQv7gX8yv15S37YOisAf/eswoaf+gi6bXjit2jLz4
8EdZiH9XFh4lEHpLHIf3Dw6k145jYJZgqGRMCGVTGGooBsgpEP2cVi9nxIeODc9d
8CI5/LSMTo/IElC0+yJ+iKvLxVdtTEYNPiAw1CLF8fCZA/HE6R/NF4KwOxcdG+OO
WoWNI9mnCxJVFSg0MTZGjBip3iJYwxLOIBG34a7dUhD9O6HZqHKOTMxR1kI3uNqM
Awci9vwckKBJ8G06PcFD/KxUfO5R8AqPvZZDpHJFoRAWdW2NCwM+qVGXi/gsyOL7
kdMWdSLDag5vmx20yRikfnL5VXP9hPwl+N0kCMxAKOEwkP3gPO4WvkzIxpkVYQdi
+tLpAakncURPCrjWSiaqOhg5xymJx0lSW95XzN6CVBxEbslDcSsOug+A3oz9gzZo
RXufg0YamYVV8p0HiuUxwn60veWDK5/qhsbTX1w+BudqQ3Bw4DKyIHVKXpiFCHS2
ohY+bS/Qfe0G6DyLBQ0Nmngh7+aNkn/2S10RoGL8i3P7YNG8HHYxNlrpTe3Em+lc
/CHs9uQSjLh/rtEY2PglQlX6yNkxo4Qr8b16adDmcJZRr7lMan3o8HvQkqGRGPmD
Byc2BVFJ+wq4W0pE4aipsq9OJADklPlIQg720Orsp3KwK3Iqii6YPoQsgDiEhiDr
LQ/ARSzsMurOAWO/i9LE1zrvzi9Z5ds+VzzIDJdDmcuK08n8D+9nebXGLLDYij9M
tlLqSKT8rbDq3DZS1rce+FV3aymXBNzkAVtIXo7/2Yqu9QyU29oDDgiy0M4aoocn
F4EBD7WbUT6EKTl9mq5c0Z2c11f2nR486PLJeEYsunsOfMqeh9o8NIVZNvDHA5t6
2Ap+as9/tw061PJlO1JJsGAeNsf03vx+MAiEDODWTVAFp3cJoiUDdJigvuI2oRWz
6+diDDMoOjHqioLMsylYzfIqB86Sb80KbwxBfnziDpil62mFo/QHFjKJpKJKQis/
C3PKVdSTDAD2h3atj26FhV3PiwMtY6z0ixwMnFfOGpWPmH7A2sFHOvkqgs2AXKNf
45aJ1+Dy/DVs7pu/pOyxWhmoXHDqveUCEDBTfRD7R0DNvvThrC9RT2t/1Lu19ZQL
hCz3MjUIVS2T5xVByd1qI6vWTq6RjaKI6l44RDVQ04Nj0cDIMJ8wT29mWYUPC1U0
5DbZlnd7YfQj7qqrgROdZyh228GkXdhhGAB3n0KyExZn3fzgZP1s6lCZ3f3VKUE+
4+4VqMIB0WHc0NNe+9fknesL6kyeLHSYRx/IwhR+IsU6UqYODFLQACOux5AzFlSE
GzDKts6zjO8osmJatt3USTqVEqgidnHa03wlU0K0ueV21KYH+mGr/LC2KoZePg2M
cEn9YAOASalv4Gn9/Dj8eSFwOth3WBYdbCHXv/tDnKSF21QcWboHhm0kCCT8OJWR
rMjkhHVJ0bxlAfvUVmSDJqZY5qWGEVOViWjFFNH9sFpGTGVXHMCsXJ7MwiG3QqZF
ZT/GzeqtRQgFlvVjZJdIgk1ryIzAbrZbxRdttptQWyH1/xbFkCKdDn+gRjmaJaW2
AJZB60+GBydVsIzz3xZm
=+RLW
-----END PGP MESSAGE-----

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC] Using checkpatch.pl

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 321 bytes --]

On Sunday 14 June 2009 22:38:19 Garrett Cooper wrote:
> -----BEGIN PGP MESSAGE-----
> Charset: ISO-8859-1
> Version: GnuPG v2.0.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> hQIOA5OwxKigUnCpEAf+OF67wA6dR9skcNJZF15Z50C5w+e5lumGihLbP4lGx2W/

looks like you hit the wrong key ...
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 332 bytes --]

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC] Using checkpatch.pl

[Subrata Modak]

Send across a patch:
1) adding checkpatch.pl to LTP,
2) those instructions/future suggestions you have mentioned, update the
same in README.

Also remember to send patches against it in future when checkpatch.pl is
updated in the kernel tree itself.

Regards--
Subrata

On Sun, 2009-06-14 at 22:03 +0530, Vijay Kumar wrote: 
> Hi everyone,
> Michal Simek patched most of the LTP code base to use the Linux kernel
> coding style. But unfortunately new patches, that are flowing in, seem
> to add coding style violations. It is better to prevent new style
> violations than to fix them later on.
> 
> The kernel developers use a perl script called checkpatch.pl to
> identify style violations in patches. We could use the same script to
> check our patches, as well. The script uses files from the kernel to
> do kernel specific checks. This can be disabled by using the --no-tree
> option. So to check an LTP patch
> 
> $ checkpatch.pl --no-tree ltp-patch
> 
> If everybody is OK with it we can add the script to the LTP source
> tree, so that everyone checks their patches against the same
> script. And Subrata can easily check for style violations before
> merging the patch.
> 
> In the future, we could also customize the script to do userspace/LTP
> specific checks, like missing mode argument when open() is invoked
> with O_CREAT flag.
> 
> Please do send in your suggestions.
> 
> Regards,
> Vijay
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing 
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC] Using checkpatch.pl

[Subrata Modak]

Vijay,

Are you working on such a patch ?

Regards--
Subrata

On Thu, 2009-06-18 at 23:01 +0530, Subrata Modak wrote: 
> Send across a patch:
> 1) adding checkpatch.pl to LTP,
> 2) those instructions/future suggestions you have mentioned, update the
> same in README.
> 
> Also remember to send patches against it in future when checkpatch.pl is
> updated in the kernel tree itself.
> 
> Regards--
> Subrata
> 
> On Sun, 2009-06-14 at 22:03 +0530, Vijay Kumar wrote: 
> > Hi everyone,
> > Michal Simek patched most of the LTP code base to use the Linux kernel
> > coding style. But unfortunately new patches, that are flowing in, seem
> > to add coding style violations. It is better to prevent new style
> > violations than to fix them later on.
> > 
> > The kernel developers use a perl script called checkpatch.pl to
> > identify style violations in patches. We could use the same script to
> > check our patches, as well. The script uses files from the kernel to
> > do kernel specific checks. This can be disabled by using the --no-tree
> > option. So to check an LTP patch
> > 
> > $ checkpatch.pl --no-tree ltp-patch
> > 
> > If everybody is OK with it we can add the script to the LTP source
> > tree, so that everyone checks their patches against the same
> > script. And Subrata can easily check for style violations before
> > merging the patch.
> > 
> > In the future, we could also customize the script to do userspace/LTP
> > specific checks, like missing mode argument when open() is invoked
> > with O_CREAT flag.
> > 
> > Please do send in your suggestions.
> > 
> > Regards,
> > Vijay
> > 
> > ------------------------------------------------------------------------------
> > Crystal Reports - New Free Runtime and 30 Day Trial
> > Check out the new simplified licensing option that enables unlimited
> > royalty-free distribution of the report engine for externally facing 
> > server and web deployment.
> > http://p.sf.net/sfu/businessobjects
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> 
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing 
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [RFC] Using checkpatch.pl

[Vijay Kumar]

Subrata Modak wrote:
> Vijay,
> 
> Are you working on such a patch ?

It is probably straight forward. But I am occupied with other things, I will send a patch this weekend.

Regards,
Vijay

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list