Re: [LTP] Report - make error of ltp-full-20090531.tgz

Serge E. Hallyn
2009-06-16T16:20:13Z

Quoting GeunSik Lim (leemgs1@gmail.com):
> On Tue, Jun 16, 2009 at 1:24 PM, Serge E. Hallyn<serue@us.ibm.com> wrote:
> > Quoting GeunSik Lim (leemgs1@gmail.com):
> >> I made patch file to solve below problem.
> >
> > well, NAK to the patch, but this is a real problem that needs to
> > be fixed.  I'll take a look in the morning, but Andrew do you know
> > offhand what the problem is with capability.h (in F11 I gather) that
> > would cause:
> Serge E. Hallyn,
>
> Thanks for your opinion about this report that I posted.
> Yes. My below patch is private patch to solve make error on Fedora 11
> distribution ( fedora11 2.6.29.4-167.fc11.i686).
> This means that my patch is not official patch file as you think.
>
> For reference,
> I used libcap 2.16 version
> at the http://ftp.kernel.org/pub/linux/libs/security/linux-privs/kernel-2.6/ .

Are you sure?

With the libcap-2.16 from kernel.org, /usr/include/sys/capability.h
#includes <sys/types.h>. The version that comes with Fedora 11's
libcap-devel-2.16-2.fc11.i586 #includes <linux/types.h> instead.
When I just fix that, my F11 system compiles cap_bound.c just fine.

Steve, do you know why that change is made?

It then moves on to the next F11-specific compile failure, namely
LTP's <test.h> ends up #including /usr/include/asm/sigcontext.h
causing the compile errors bc of undefined __u64 and __u32,
which I can fix by adding:

#define __u64 u_int64_t
#define __u32 u_int32_t

to <sys/types.h>. So perhaps it would be prudent to add them
to the top of LTP's test.h?

It woudl be better to figure out why that's happening in the
first place...

thanks,
-serge