Re: [LTP] [FIX PATCH] ltp-add_key

[Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>]

* Subrata Modak <subrata@linux.vnet.ibm.com> [2009-06-18 23:01:55]:

> Great to see you fix these issues and send across the fixes. However, i
> remember Kamalesh working on similar type of fixes.
> 
> Lets hear from Kamalesh, whether he has something additional from this
> series of patches, or, some other fixes in each patch apart from what
> you have already provided.
> 
> Kamalesh,
> 
> Would you like to say something here ?
> 
> Another suggestion. Naresh, next time when you send patches pertaining
> to one particular issue observed in several tests, then no. the patches,
> like [PATCH 00/N] to [PATCH N/N].

It could be nice to add a section in ltp-howto on sending patch sets.

> 
> Regards--
> Subrata
> 
> On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: 
> > Hi,
> > 
> > I have noticed following failures and fixed.
> > 1. add_key01.c
> > 2. add_key02.c
> > 
> > 
> > Please find the patch below and as attachment.
> > 
> > Best regards
> > Naresh Kamboju
> > 
> > Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
> > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c
> > b/testcases/kernel/syscalls/add_key/add_key01.c
> > --- a/testcases/kernel/syscalls/add_key/add_key01.c	2009-05-21
> > 23:39:37.000000000 +0530
> > +++ b/testcases/kernel/syscalls/add_key/add_key01.c	2009-06-17
> > 23:00:15.000000000 +0530
> > @@ -125,7 +125,7 @@
> >          for (lc = 0; TEST_LOOPING(lc); ++lc) {
> >                  Tst_count = 0;
> >                  for (testno = 0; testno < TST_TOTAL; ++testno) {
> > -                     TEST(result = syscall(286, "keyring", "wjkey",
> > NULL, 0, KEY_SPEC_THREAD_KEYRING));     //call add_key()
> > +                     TEST(result = syscall(__NR_add_key, "keyring",
> > "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING));     //call add_key()
> >                       if(TEST_RETURN != -1) {
> >          		tst_resm(TPASS, "add_key call succeeded");
> >                          cleanup();
> > @@ -139,4 +139,3 @@
> >          }	
> >          tst_exit();
> >  }
> > -

Can you remove the result variable from the TEST() and make similar
changes to add_keys, set_tid_address, set_thread_area syscalls and
resubmit the patches.

 testcases/kernel/syscalls/add_key/add_key01.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c
index 67a4c2f..56fbe1a 100644
--- a/testcases/kernel/syscalls/add_key/add_key01.c
+++ b/testcases/kernel/syscalls/add_key/add_key01.c
@@ -109,7 +109,6 @@ void setup() {
 }
 
 int main(int ac, char **av) {
-        int result;
         int lc;                 /* loop counter */
         char *msg;              /* message returned from parse_opts */
 	
@@ -125,7 +124,7 @@ int main(int ac, char **av) {
         for (lc = 0; TEST_LOOPING(lc); ++lc) {
                 Tst_count = 0;
                 for (testno = 0; testno < TST_TOTAL; ++testno) {
-                     TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING));     //call add_key()
+                     TEST(syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING));     //call add_key()
                      if(TEST_RETURN != -1) {
         		tst_resm(TPASS, "add_key call succeeded");
                         cleanup();
			
			
			Kamalesh

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list