* [LTP] [FIX PATCH] ltp-add_key
@ 2009-06-17 20:18 naresh kamboju
2009-06-18 17:31 ` Subrata Modak
0 siblings, 1 reply; 5+ messages in thread
From: naresh kamboju @ 2009-06-17 20:18 UTC (permalink / raw)
To: ltp-list
Cc: maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov,
rohit.170309
[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]
Hi,
I have noticed following failures and fixed.
1. add_key01.c
2. add_key02.c
Please find the patch below and as attachment.
Best regards
Naresh Kamboju
Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c
b/testcases/kernel/syscalls/add_key/add_key01.c
--- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21
23:39:37.000000000 +0530
+++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17
23:00:15.000000000 +0530
@@ -125,7 +125,7 @@
for (lc = 0; TEST_LOOPING(lc); ++lc) {
Tst_count = 0;
for (testno = 0; testno < TST_TOTAL; ++testno) {
- TEST(result = syscall(286, "keyring", "wjkey",
NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key()
+ TEST(result = syscall(__NR_add_key, "keyring",
"wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key()
if(TEST_RETURN != -1) {
tst_resm(TPASS, "add_key call succeeded");
cleanup();
@@ -139,4 +139,3 @@
}
tst_exit();
}
-
diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c
b/testcases/kernel/syscalls/add_key/add_key02.c
--- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21
23:40:50.000000000 +0530
+++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-17
23:47:48.000000000 +0530
@@ -140,7 +140,7 @@
for (testno = 0; testno < TST_TOTAL; ++testno) {
for(i=0; i<test_count; i++) {
- TEST(syscall(286, test_cases[i].type,
test_cases[i].desc, test_cases[i].payload, test_cases[i].plen,
KEY_SPEC_USER_KEYRING)); //call add_key()
+ TEST(syscall(__NR_add_key, test_cases[i].type,
test_cases[i].desc, test_cases[i].payload, test_cases[i].plen,
KEY_SPEC_USER_KEYRING)); //call add_key()
if(TEST_RETURN != -1){
tst_resm(TINFO,"call add_key() with wrong
args succeed, but should fail");
fail++;
@@ -170,4 +170,3 @@
}
tst_exit();
}
-
[-- Attachment #2: ltp-fix-add_key.patch --]
[-- Type: application/octet-stream, Size: 1879 bytes --]
diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c
--- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 23:39:37.000000000 +0530
+++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 23:00:15.000000000 +0530
@@ -125,7 +125,7 @@
for (lc = 0; TEST_LOOPING(lc); ++lc) {
Tst_count = 0;
for (testno = 0; testno < TST_TOTAL; ++testno) {
- TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key()
+ TEST(result = syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key()
if(TEST_RETURN != -1) {
tst_resm(TPASS, "add_key call succeeded");
cleanup();
@@ -139,4 +139,3 @@
}
tst_exit();
}
-
diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c b/testcases/kernel/syscalls/add_key/add_key02.c
--- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 23:40:50.000000000 +0530
+++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-17 23:47:48.000000000 +0530
@@ -140,7 +140,7 @@
for (testno = 0; testno < TST_TOTAL; ++testno) {
for(i=0; i<test_count; i++) {
- TEST(syscall(286, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key()
+ TEST(syscall(__NR_add_key, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key()
if(TEST_RETURN != -1){
tst_resm(TINFO,"call add_key() with wrong args succeed, but should fail");
fail++;
@@ -170,4 +170,3 @@
}
tst_exit();
}
-
[-- Attachment #3: Type: text/plain, Size: 332 bytes --]
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [LTP] [FIX PATCH] ltp-add_key 2009-06-17 20:18 [LTP] [FIX PATCH] ltp-add_key naresh kamboju @ 2009-06-18 17:31 ` Subrata Modak 2009-06-19 5:41 ` naresh kamboju 2009-06-19 9:13 ` Kamalesh Babulal 0 siblings, 2 replies; 5+ messages in thread From: Subrata Modak @ 2009-06-18 17:31 UTC (permalink / raw) To: naresh kamboju, Kamalesh Babulal, Munipradeep Beerakam Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov, rohit.170309 Great to see you fix these issues and send across the fixes. However, i remember Kamalesh working on similar type of fixes. Lets hear from Kamalesh, whether he has something additional from this series of patches, or, some other fixes in each patch apart from what you have already provided. Kamalesh, Would you like to say something here ? Another suggestion. Naresh, next time when you send patches pertaining to one particular issue observed in several tests, then no. the patches, like [PATCH 00/N] to [PATCH N/N]. Regards-- Subrata On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: > Hi, > > I have noticed following failures and fixed. > 1. add_key01.c > 2. add_key02.c > > > Please find the patch below and as attachment. > > Best regards > Naresh Kamboju > > Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com > > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c > b/testcases/kernel/syscalls/add_key/add_key01.c > --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 > 23:39:37.000000000 +0530 > +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 > 23:00:15.000000000 +0530 > @@ -125,7 +125,7 @@ > for (lc = 0; TEST_LOOPING(lc); ++lc) { > Tst_count = 0; > for (testno = 0; testno < TST_TOTAL; ++testno) { > - TEST(result = syscall(286, "keyring", "wjkey", > NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > + TEST(result = syscall(__NR_add_key, "keyring", > "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > if(TEST_RETURN != -1) { > tst_resm(TPASS, "add_key call succeeded"); > cleanup(); > @@ -139,4 +139,3 @@ > } > tst_exit(); > } > - > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c > b/testcases/kernel/syscalls/add_key/add_key02.c > --- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 > 23:40:50.000000000 +0530 > +++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-17 > 23:47:48.000000000 +0530 > @@ -140,7 +140,7 @@ > for (testno = 0; testno < TST_TOTAL; ++testno) { > > for(i=0; i<test_count; i++) { > - TEST(syscall(286, test_cases[i].type, > test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, > KEY_SPEC_USER_KEYRING)); //call add_key() > + TEST(syscall(__NR_add_key, test_cases[i].type, > test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, > KEY_SPEC_USER_KEYRING)); //call add_key() > if(TEST_RETURN != -1){ > tst_resm(TINFO,"call add_key() with wrong > args succeed, but should fail"); > fail++; > @@ -170,4 +170,3 @@ > } > tst_exit(); > } > - ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [FIX PATCH] ltp-add_key 2009-06-18 17:31 ` Subrata Modak @ 2009-06-19 5:41 ` naresh kamboju 2009-06-19 9:13 ` Kamalesh Babulal 1 sibling, 0 replies; 5+ messages in thread From: naresh kamboju @ 2009-06-19 5:41 UTC (permalink / raw) To: subrata Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov, rohit.170309 Hi Subrata, I will wait for Kamalesh comments. Thanks for your suggestion. I thought that [PATCH 00/N] can be used at the time of new test cases proposed. I have sent [FIX PATCH] that is the reason. Can we have a different kind of representation for New Test cases and Fix patch. Or is it a standard? Please provide me the link for standard. Your suggestions are welcome :) Best regards Naresh Kamboju On Thu, Jun 18, 2009 at 11:01 PM, Subrata Modak<subrata@linux.vnet.ibm.com> wrote: > Great to see you fix these issues and send across the fixes. However, i > remember Kamalesh working on similar type of fixes. > > Lets hear from Kamalesh, whether he has something additional from this > series of patches, or, some other fixes in each patch apart from what > you have already provided. > > Kamalesh, > > Would you like to say something here ? > > Another suggestion. Naresh, next time when you send patches pertaining > to one particular issue observed in several tests, then no. the patches, > like [PATCH 00/N] to [PATCH N/N]. > > Regards-- > Subrata > > On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: >> Hi, >> >> I have noticed following failures and fixed. >> 1. add_key01.c >> 2. add_key02.c >> >> >> Please find the patch below and as attachment. >> >> Best regards >> Naresh Kamboju >> >> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com > >> diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c >> b/testcases/kernel/syscalls/add_key/add_key01.c >> --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 >> 23:39:37.000000000 +0530 >> +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 >> 23:00:15.000000000 +0530 >> @@ -125,7 +125,7 @@ >> for (lc = 0; TEST_LOOPING(lc); ++lc) { >> Tst_count = 0; >> for (testno = 0; testno < TST_TOTAL; ++testno) { >> - TEST(result = syscall(286, "keyring", "wjkey", >> NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> + TEST(result = syscall(__NR_add_key, "keyring", >> "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> if(TEST_RETURN != -1) { >> tst_resm(TPASS, "add_key call succeeded"); >> cleanup(); >> @@ -139,4 +139,3 @@ >> } >> tst_exit(); >> } >> - >> diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c >> b/testcases/kernel/syscalls/add_key/add_key02.c >> --- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 >> 23:40:50.000000000 +0530 >> +++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-17 >> 23:47:48.000000000 +0530 >> @@ -140,7 +140,7 @@ >> for (testno = 0; testno < TST_TOTAL; ++testno) { >> >> for(i=0; i<test_count; i++) { >> - TEST(syscall(286, test_cases[i].type, >> test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, >> KEY_SPEC_USER_KEYRING)); //call add_key() >> + TEST(syscall(__NR_add_key, test_cases[i].type, >> test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, >> KEY_SPEC_USER_KEYRING)); //call add_key() >> if(TEST_RETURN != -1){ >> tst_resm(TINFO,"call add_key() with wrong >> args succeed, but should fail"); >> fail++; >> @@ -170,4 +170,3 @@ >> } >> tst_exit(); >> } >> - > > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [FIX PATCH] ltp-add_key 2009-06-18 17:31 ` Subrata Modak 2009-06-19 5:41 ` naresh kamboju @ 2009-06-19 9:13 ` Kamalesh Babulal 2009-06-19 12:57 ` naresh kamboju 1 sibling, 1 reply; 5+ messages in thread From: Kamalesh Babulal @ 2009-06-19 9:13 UTC (permalink / raw) To: Subrata Modak Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov, rohit.170309, naresh kamboju * Subrata Modak <subrata@linux.vnet.ibm.com> [2009-06-18 23:01:55]: > Great to see you fix these issues and send across the fixes. However, i > remember Kamalesh working on similar type of fixes. > > Lets hear from Kamalesh, whether he has something additional from this > series of patches, or, some other fixes in each patch apart from what > you have already provided. > > Kamalesh, > > Would you like to say something here ? > > Another suggestion. Naresh, next time when you send patches pertaining > to one particular issue observed in several tests, then no. the patches, > like [PATCH 00/N] to [PATCH N/N]. It could be nice to add a section in ltp-howto on sending patch sets. > > Regards-- > Subrata > > On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: > > Hi, > > > > I have noticed following failures and fixed. > > 1. add_key01.c > > 2. add_key02.c > > > > > > Please find the patch below and as attachment. > > > > Best regards > > Naresh Kamboju > > > > Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com > > > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c > > b/testcases/kernel/syscalls/add_key/add_key01.c > > --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 > > 23:39:37.000000000 +0530 > > +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 > > 23:00:15.000000000 +0530 > > @@ -125,7 +125,7 @@ > > for (lc = 0; TEST_LOOPING(lc); ++lc) { > > Tst_count = 0; > > for (testno = 0; testno < TST_TOTAL; ++testno) { > > - TEST(result = syscall(286, "keyring", "wjkey", > > NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > > + TEST(result = syscall(__NR_add_key, "keyring", > > "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > > if(TEST_RETURN != -1) { > > tst_resm(TPASS, "add_key call succeeded"); > > cleanup(); > > @@ -139,4 +139,3 @@ > > } > > tst_exit(); > > } > > - Can you remove the result variable from the TEST() and make similar changes to add_keys, set_tid_address, set_thread_area syscalls and resubmit the patches. testcases/kernel/syscalls/add_key/add_key01.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c index 67a4c2f..56fbe1a 100644 --- a/testcases/kernel/syscalls/add_key/add_key01.c +++ b/testcases/kernel/syscalls/add_key/add_key01.c @@ -109,7 +109,6 @@ void setup() { } int main(int ac, char **av) { - int result; int lc; /* loop counter */ char *msg; /* message returned from parse_opts */ @@ -125,7 +124,7 @@ int main(int ac, char **av) { for (lc = 0; TEST_LOOPING(lc); ++lc) { Tst_count = 0; for (testno = 0; testno < TST_TOTAL; ++testno) { - TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() + TEST(syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() if(TEST_RETURN != -1) { tst_resm(TPASS, "add_key call succeeded"); cleanup(); Kamalesh ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [FIX PATCH] ltp-add_key 2009-06-19 9:13 ` Kamalesh Babulal @ 2009-06-19 12:57 ` naresh kamboju 0 siblings, 0 replies; 5+ messages in thread From: naresh kamboju @ 2009-06-19 12:57 UTC (permalink / raw) To: Kamalesh Babulal Cc: ltp-list, maxin john, brinda_mn, Manas Kumar Nayak, Oleg Nesterov, rohit.170309 [-- Attachment #1: Type: text/plain, Size: 6005 bytes --] Hi, Thanks for your review comments. I have attached and placed below the latest patch. Best regards Naresh Kamboju Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 23:39:37.000000000 +0530 +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-19 17:36:22.000000000 +0530 @@ -109,7 +109,6 @@ } int main(int ac, char **av) { - int result; int lc; /* loop counter */ char *msg; /* message returned from parse_opts */ @@ -125,7 +124,7 @@ for (lc = 0; TEST_LOOPING(lc); ++lc) { Tst_count = 0; for (testno = 0; testno < TST_TOTAL; ++testno) { - TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() + TEST(syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() if(TEST_RETURN != -1) { tst_resm(TPASS, "add_key call succeeded"); cleanup(); @@ -139,4 +138,3 @@ } tst_exit(); } - diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c b/testcases/kernel/syscalls/add_key/add_key02.c --- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 23:40:50.000000000 +0530 +++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-19 17:35:55.000000000 +0530 @@ -140,7 +140,7 @@ for (testno = 0; testno < TST_TOTAL; ++testno) { for(i=0; i<test_count; i++) { - TEST(syscall(286, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key() + TEST(syscall(__NR_add_key, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key() if(TEST_RETURN != -1){ tst_resm(TINFO,"call add_key() with wrong args succeed, but should fail"); fail++; @@ -170,4 +170,3 @@ } tst_exit(); } - On Fri, Jun 19, 2009 at 2:43 PM, Kamalesh Babulal<kamalesh@linux.vnet.ibm.com> wrote: > * Subrata Modak <subrata@linux.vnet.ibm.com> [2009-06-18 23:01:55]: > >> Great to see you fix these issues and send across the fixes. However, i >> remember Kamalesh working on similar type of fixes. >> >> Lets hear from Kamalesh, whether he has something additional from this >> series of patches, or, some other fixes in each patch apart from what >> you have already provided. >> >> Kamalesh, >> >> Would you like to say something here ? >> >> Another suggestion. Naresh, next time when you send patches pertaining >> to one particular issue observed in several tests, then no. the patches, >> like [PATCH 00/N] to [PATCH N/N]. > > It could be nice to add a section in ltp-howto on sending patch sets. > >> >> Regards-- >> Subrata >> >> On Thu, 2009-06-18 at 01:48 +0530, naresh kamboju wrote: >> > Hi, >> > >> > I have noticed following failures and fixed. >> > 1. add_key01.c >> > 2. add_key02.c >> > >> > >> > Please find the patch below and as attachment. >> > >> > Best regards >> > Naresh Kamboju >> > >> > Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com > >> > diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c >> > b/testcases/kernel/syscalls/add_key/add_key01.c >> > --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 >> > 23:39:37.000000000 +0530 >> > +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-17 >> > 23:00:15.000000000 +0530 >> > @@ -125,7 +125,7 @@ >> > for (lc = 0; TEST_LOOPING(lc); ++lc) { >> > Tst_count = 0; >> > for (testno = 0; testno < TST_TOTAL; ++testno) { >> > - TEST(result = syscall(286, "keyring", "wjkey", >> > NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> > + TEST(result = syscall(__NR_add_key, "keyring", >> > "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() >> > if(TEST_RETURN != -1) { >> > tst_resm(TPASS, "add_key call succeeded"); >> > cleanup(); >> > @@ -139,4 +139,3 @@ >> > } >> > tst_exit(); >> > } >> > - > > Can you remove the result variable from the TEST() and make similar > changes to add_keys, set_tid_address, set_thread_area syscalls and > resubmit the patches. > > testcases/kernel/syscalls/add_key/add_key01.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c > index 67a4c2f..56fbe1a 100644 > --- a/testcases/kernel/syscalls/add_key/add_key01.c > +++ b/testcases/kernel/syscalls/add_key/add_key01.c > @@ -109,7 +109,6 @@ void setup() { > } > > int main(int ac, char **av) { > - int result; > int lc; /* loop counter */ > char *msg; /* message returned from parse_opts */ > > @@ -125,7 +124,7 @@ int main(int ac, char **av) { > for (lc = 0; TEST_LOOPING(lc); ++lc) { > Tst_count = 0; > for (testno = 0; testno < TST_TOTAL; ++testno) { > - TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > + TEST(syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() > if(TEST_RETURN != -1) { > tst_resm(TPASS, "add_key call succeeded"); > cleanup(); > > > Kamalesh > [-- Attachment #2: ltp-fix-add_key.patch --] [-- Type: application/octet-stream, Size: 2074 bytes --] diff -Naurb a/testcases/kernel/syscalls/add_key/add_key01.c b/testcases/kernel/syscalls/add_key/add_key01.c --- a/testcases/kernel/syscalls/add_key/add_key01.c 2009-05-21 23:39:37.000000000 +0530 +++ b/testcases/kernel/syscalls/add_key/add_key01.c 2009-06-19 17:36:22.000000000 +0530 @@ -109,7 +109,6 @@ } int main(int ac, char **av) { - int result; int lc; /* loop counter */ char *msg; /* message returned from parse_opts */ @@ -125,7 +124,7 @@ for (lc = 0; TEST_LOOPING(lc); ++lc) { Tst_count = 0; for (testno = 0; testno < TST_TOTAL; ++testno) { - TEST(result = syscall(286, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() + TEST(syscall(__NR_add_key, "keyring", "wjkey", NULL, 0, KEY_SPEC_THREAD_KEYRING)); //call add_key() if(TEST_RETURN != -1) { tst_resm(TPASS, "add_key call succeeded"); cleanup(); @@ -139,4 +138,3 @@ } tst_exit(); } - diff -Naurb a/testcases/kernel/syscalls/add_key/add_key02.c b/testcases/kernel/syscalls/add_key/add_key02.c --- a/testcases/kernel/syscalls/add_key/add_key02.c 2009-05-21 23:40:50.000000000 +0530 +++ b/testcases/kernel/syscalls/add_key/add_key02.c 2009-06-19 17:35:55.000000000 +0530 @@ -140,7 +140,7 @@ for (testno = 0; testno < TST_TOTAL; ++testno) { for(i=0; i<test_count; i++) { - TEST(syscall(286, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key() + TEST(syscall(__NR_add_key, test_cases[i].type, test_cases[i].desc, test_cases[i].payload, test_cases[i].plen, KEY_SPEC_USER_KEYRING)); //call add_key() if(TEST_RETURN != -1){ tst_resm(TINFO,"call add_key() with wrong args succeed, but should fail"); fail++; @@ -170,4 +170,3 @@ } tst_exit(); } - [-- Attachment #3: Type: text/plain, Size: 332 bytes --] ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects [-- Attachment #4: Type: text/plain, Size: 155 bytes --] _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-19 13:04 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-06-17 20:18 [LTP] [FIX PATCH] ltp-add_key naresh kamboju 2009-06-18 17:31 ` Subrata Modak 2009-06-19 5:41 ` naresh kamboju 2009-06-19 9:13 ` Kamalesh Babulal 2009-06-19 12:57 ` naresh kamboju
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox