* [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
@ 2009-06-10 7:14 Munipradeep Beerakam
2009-06-18 17:31 ` Subrata Modak
0 siblings, 1 reply; 6+ messages in thread
From: Munipradeep Beerakam @ 2009-06-10 7:14 UTC (permalink / raw)
To: ltp-list
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
Hi,
Here is the attachment to fix the configuration error in
get_mempolicy01.c
Actually it should not fail due to configuration error. So changed the
necessary.
Thanks
Muni
[-- Attachment #2: get_mempolicy01.patch --]
[-- Type: text/x-patch, Size: 1079 bytes --]
--- a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10 07:08:08.000000000 -0400
+++ b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10 07:12:16.000000000 -0400
@@ -296,7 +296,7 @@
TEST(rc = syscall(__NR_set_mempolicy, tc->policy,&nodemask, maxnode));
if (TEST_RETURN < 0) {
- tst_resm(TFAIL, "set_mempolicy() failed - errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
+ tst_resm(TCONF, "set_mempolicy() failed - errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
result = 1;
cleanup();
tst_exit();
@@ -307,7 +307,7 @@
// mmap memory
p = mmap(NULL, len, PROT_READ|PROT_WRITE,MAP_PRIVATE|MAP_ANONYMOUS, 0, 0);
if (p == (void*)-1) {
- tst_resm(TFAIL, "malloc failed - errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
+ tst_resm(TCONF, "malloc failed - errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
result = 1;
cleanup();
tst_exit();
[-- Attachment #3: Type: text/plain, Size: 332 bytes --]
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
2009-06-10 7:14 [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error Munipradeep Beerakam
@ 2009-06-18 17:31 ` Subrata Modak
2009-06-19 8:55 ` Munipradeep Beerakam
0 siblings, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-06-18 17:31 UTC (permalink / raw)
To: Munipradeep Beerakam; +Cc: ltp-list
Hi Muni,
On Wed, 2009-06-10 at 12:44 +0530, Munipradeep Beerakam wrote:
> Hi,
>
> Here is the attachment to fix the configuration error in
> get_mempolicy01.c
> Actually it should not fail due to configuration error. So changed the
> necessary.
>
> Thanks
> Muni
>
>
>
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (get_mempolicy01.patch)
>
>
> ---
> a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10
> 07:08:08.000000000 -0400
> +++
> b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10
> 07:12:16.000000000 -0400
> @@ -296,7 +296,7 @@
> TEST(rc = syscall(__NR_set_mempolicy,
> tc->policy,&nodemask, maxnode));
>
> if (TEST_RETURN < 0) {
> - tst_resm(TFAIL, "set_mempolicy() failed -
> errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
> + tst_resm(TCONF, "set_mempolicy() failed -
> errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
> result = 1;
> cleanup();
> tst_exit();
> @@ -307,7 +307,7 @@
> // mmap memory
> p = mmap(NULL, len, PROT_READ|PROT_WRITE,MAP_PRIVATE|
> MAP_ANONYMOUS, 0, 0);
> if (p == (void*)-1) {
> - tst_resm(TFAIL, "malloc failed - errno = %d :
> %s",TEST_ERRNO, strerror(TEST_ERRNO));
> + tst_resm(TCONF, "malloc failed - errno = %d :
> %s",TEST_ERRNO, strerror(TEST_ERRNO));
> result = 1;
> cleanup();
> tst_exit();
The problem reported on your machine is function not implemented.
However, if you change the FAIL to blindly CONF, that will cause issues
like actual failures reported wrongly.
See, whether you can find out ways to isolate only function not
implemented part.
Regards--
Subrata
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
2009-06-18 17:31 ` Subrata Modak
@ 2009-06-19 8:55 ` Munipradeep Beerakam
2009-06-23 14:50 ` Subrata Modak
0 siblings, 1 reply; 6+ messages in thread
From: Munipradeep Beerakam @ 2009-06-19 8:55 UTC (permalink / raw)
To: subrata; +Cc: ltp-list
On Thu, 2009-06-18 at 23:01 +0530, Subrata Modak wrote:
Hi Subrata,
> Hi Muni,
>
> On Wed, 2009-06-10 at 12:44 +0530, Munipradeep Beerakam wrote:
> > Hi,
> >
> > Here is the attachment to fix the configuration error in
> > get_mempolicy01.c
> > Actually it should not fail due to configuration error. So changed the
> > necessary.
> >
> > Thanks
> > Muni
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > differences
> > between files
> > attachment
> > (get_mempolicy01.patch)
> >
> >
> > ---
> > a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10
> > 07:08:08.000000000 -0400
> > +++
> > b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c 2009-06-10
> > 07:12:16.000000000 -0400
> > @@ -296,7 +296,7 @@
> > TEST(rc = syscall(__NR_set_mempolicy,
> > tc->policy,&nodemask, maxnode));
> >
> > if (TEST_RETURN < 0) {
> > - tst_resm(TFAIL, "set_mempolicy() failed -
> > errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
> > + tst_resm(TCONF, "set_mempolicy() failed -
> > errno = %d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
> > result = 1;
> > cleanup();
> > tst_exit();
> > @@ -307,7 +307,7 @@
> > // mmap memory
> > p = mmap(NULL, len, PROT_READ|PROT_WRITE,MAP_PRIVATE|
> > MAP_ANONYMOUS, 0, 0);
> > if (p == (void*)-1) {
> > - tst_resm(TFAIL, "malloc failed - errno = %d :
> > %s",TEST_ERRNO, strerror(TEST_ERRNO));
> > + tst_resm(TCONF, "malloc failed - errno = %d :
> > %s",TEST_ERRNO, strerror(TEST_ERRNO));
> > result = 1;
> > cleanup();
> > tst_exit();
>
> The problem reported on your machine is function not implemented.
> However, if you change the FAIL to blindly CONF, that will cause issues
> like actual failures reported wrongly.
>
> See, whether you can find out ways to isolate only function not
> implemented part.
>
> Regards--
> Subrata
>
>
As I don't know what are all the error reporting options LTP have, I
changed it to CONF. We can change it accordingly to need. Can we report
it as BROKEN, as set_mempolicy is preventing the get_mempolicy test to
run?
Regards
Muni
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
2009-06-19 8:55 ` Munipradeep Beerakam
@ 2009-06-23 14:50 ` Subrata Modak
2009-06-23 16:06 ` Jiri Palecek
0 siblings, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-06-23 14:50 UTC (permalink / raw)
To: Munipradeep Beerakam; +Cc: ltp-list
> >
> >
> As I don't know what are all the error reporting options LTP have, I
> changed it to CONF. We can change it accordingly to need. Can we report
> it as BROKEN, as set_mempolicy is preventing the get_mempolicy test to
> run?
Muni,
Jiriś patch checked in today should fix this:
Subject: [LTP] [PATCH] Define some syscall numbers in the
linux_syscall_numbers.h file, not to get build failures or crappy
results on other architectures which lack them
Regards--
Subrata
>
> Regards
> Muni
>
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
2009-06-23 14:50 ` Subrata Modak
@ 2009-06-23 16:06 ` Jiri Palecek
2009-06-25 9:10 ` Subrata Modak
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Palecek @ 2009-06-23 16:06 UTC (permalink / raw)
To: subrata; +Cc: ltp-list
On Tuesday 23 June 2009 16:50:42 Subrata Modak wrote:
> > >
> > >
> > As I don't know what are all the error reporting options LTP have, I
> > changed it to CONF. We can change it accordingly to need. Can we report
> > it as BROKEN, as set_mempolicy is preventing the get_mempolicy test to
> > run?
>
> Muni,
>
> Jiriś patch checked in today should fix this:
>
> Subject: [LTP] [PATCH] Define some syscall numbers in the
> linux_syscall_numbers.h file, not to get build failures or crappy
> results on other architectures which lack them
Well, yes and no. The patch does handle the situation (sort of), but it still results in a TBROK (which is wrong, I admit). I think this area (ie. syscalls which are or aren't present in some kernels) should be handled more systematically, especially after what I went through uploading the last version of ltp to Debian. I will think of it and produce some example patches after I send other patches I have in the queue.
Regards
Jiri Palecek
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error
2009-06-23 16:06 ` Jiri Palecek
@ 2009-06-25 9:10 ` Subrata Modak
0 siblings, 0 replies; 6+ messages in thread
From: Subrata Modak @ 2009-06-25 9:10 UTC (permalink / raw)
To: Jiri Palecek; +Cc: ltp-list
On Tue, 2009-06-23 at 18:06 +0200, Jiri Palecek wrote:
> On Tuesday 23 June 2009 16:50:42 Subrata Modak wrote:
> > > >
> > > >
> > > As I don't know what are all the error reporting options LTP have, I
> > > changed it to CONF. We can change it accordingly to need. Can we report
> > > it as BROKEN, as set_mempolicy is preventing the get_mempolicy test to
> > > run?
> >
> > Muni,
> >
> > Jiriś patch checked in today should fix this:
> >
> > Subject: [LTP] [PATCH] Define some syscall numbers in the
> > linux_syscall_numbers.h file, not to get build failures or crappy
> > results on other architectures which lack them
>
Updating/cleaning linux_syscall_numbers.h is a good idea always.
Regards--
Subrata
> Well, yes and no. The patch does handle the situation (sort of), but it still results in a TBROK (which is wrong, I admit). I think this area (ie. syscalls which are or aren't present in some kernels) should be handled more systematically, especially after what I went through uploading the last version of ltp to Debian. I will think of it and produce some example patches after I send other patches I have in the queue.
>
> Regards
> Jiri Palecek
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-25 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 7:14 [LTP] [PATCH]get_mempolicy01: fix for changing failure due to configuration error Munipradeep Beerakam
2009-06-18 17:31 ` Subrata Modak
2009-06-19 8:55 ` Munipradeep Beerakam
2009-06-23 14:50 ` Subrata Modak
2009-06-23 16:06 ` Jiri Palecek
2009-06-25 9:10 ` Subrata Modak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox