From: Jiri Palecek <jpalecek@web.de>
To: subrata@linux.vnet.ibm.com
Cc: ltp-list <ltp-list@lists.sf.net>,
naresh kamboju <naresh.kernel@gmail.com>
Subject: Re: [LTP] Request for Hold [FIX PATCH]
Date: Tue, 23 Jun 2009 18:19:54 +0200 [thread overview]
Message-ID: <200906231819.55008.jpalecek@web.de> (raw)
In-Reply-To: <1245768620.4860.87.camel@subratamodak.linux.ibm.com>
On Tuesday 23 June 2009 16:50:20 Subrata Modak wrote:
> Do you see Jiriś patch:
>
>
> fixing those issues you are seeing. If yes, then it could be safe to
> check-in your patches. Please confirm.
>
> Regards--
> Subrata
>
> On Mon, 2009-06-22 at 01:58 +0530, naresh kamboju wrote:
> > Hi Subrata,
> >
> > please hold these patches.(Don't commit)
> > List of patches submitted in last week.
> >
> > ltp-fix-add_key.patch
> > ltp-fix-bdflush.patch
> > ltp-fix-keyctl.patch
> > ltp-fix-newuname.patch
> > ltp-fix-rt_sigprocmask.patch
> > ltp-fix-rt_sigsuspend.patch
> > ltp-fix-set_thread_area.patch
> > ltp-fix-set_tid_address.patch
> > ltp-fix-ssetmask.patch
> > ltp-fix-tkill.patch
> >
> > I have noticed build errors on different ARCH other than x86 ARCH.
> > i'll test with most of the ARCH and resubmit these patches with Multi
> > Architecture support and share with LTP on 23-June-2009 along with
> > results HTML.
Just a side note to this whole issue: I think these patches should have been applied long ago. The fact that it makes the tests wrong is not an obstacle for applying, IMHO - the tests are just as wrong without them. Even more, they are wrong in many other areas (like immoderate use of the TEST macro without reason even in places where it's incorrect, doubtful test logic, strange usage of test status messages and last, but not least, really ghastly code style). And these should be fixed one by one, and waiting only makes it take longer.
Regards
Jiri Palecek
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2009-06-23 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f5a7b3810906211328r7763fc7fx51e6eaf8cb3e560c@mail.gmail.com>
2009-06-23 14:50 ` [LTP] Request for Hold [FIX PATCH] Subrata Modak
2009-06-23 16:19 ` Jiri Palecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906231819.55008.jpalecek@web.de \
--to=jpalecek@web.de \
--cc=ltp-list@lists.sf.net \
--cc=naresh.kernel@gmail.com \
--cc=subrata@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox