From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Poornima Nayak <poornima.nayak@in.ibm.com>,
Daniel Lezcano <daniel.lezcano@free.fr>,
Veerendra C <vechandr@in.ibm.com>,
Munipradeep <mbeeraka@in.ibm.com>
Subject: Re: [LTP] [PATCH 4/4] netns: Change interpretters from sh to bash
Date: Thu, 2 Jul 2009 14:35:46 -0400 [thread overview]
Message-ID: <200907021435.48510.vapier@gentoo.org> (raw)
In-Reply-To: <20090702090532.GF19135@count0.beaverton.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 720 bytes --]
On Thursday 02 July 2009 05:05:32 Matt Helsley wrote:
> As best I can tell these tests do not use true sh syntax -- they use bash
> syntax. Rather than bother hunting down all the bash-isms just convert
> them to use bash as their interpretter.
the changelog doesnt seem to jive with the commit. if you were merely
changing the shebang, why did you also fix the bashisms like s/==/-eq/ ?
at any rate, someone (i dont recall who) posted fixes to these files recently
to de-bashify them. there was some feedback though, so perhaps you should
address those minor issues and submit an updated patch.
in general, converting sh to bash is a bad idea as it can cause issues for us
embedded peeps.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-07-02 18:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-02 8:48 [LTP] [PATCH 1/4] netns: Report version of iproute2 tools in ver_linux Matt Helsley
2009-07-02 8:58 ` [LTP] [PATCH 2/4] netns: Add ip tools check to netns tests Matt Helsley
2009-07-06 15:50 ` Subrata Modak
2009-07-02 9:02 ` [LTP] [PATCH 3/4] netns: Fixup non-sh syntax Matt Helsley
2009-07-03 3:33 ` Garrett Cooper
2009-07-02 9:05 ` [LTP] [PATCH 4/4] netns: Change interpretters from sh to bash Matt Helsley
2009-07-02 18:35 ` Mike Frysinger [this message]
2009-07-02 20:32 ` Matt Helsley
2009-07-02 22:09 ` Mike Frysinger
2009-07-06 21:51 ` [LTP] [PATCH] Remove bashisms (WAS Re: [PATCH 4/4] netns: Change interpretters from sh to bash) Matt Helsley
2009-07-06 21:57 ` Garrett Cooper
2009-07-06 23:10 ` Jiří Paleček
2009-07-06 23:24 ` Mike Frysinger
2009-07-07 1:30 ` Matt Helsley
2009-07-06 15:50 ` [LTP] [PATCH 4/4] netns: Change interpretters from sh to bash Subrata Modak
2009-07-06 15:50 ` [LTP] [PATCH 1/4] netns: Report version of iproute2 tools in ver_linux Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907021435.48510.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=daniel.lezcano@free.fr \
--cc=ltp-list@lists.sourceforge.net \
--cc=mbeeraka@in.ibm.com \
--cc=poornima.nayak@in.ibm.com \
--cc=vechandr@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox