Re: [LTP] [PATCH] Fix some bashisms

Garrett Cooper
2009-10-26T19:37:22Z

On Mon, Oct 26, 2009 at 10:02 AM, Subrata Modak
<subrata@linux.vnet.ibm.com> wrote:
> On Wed, 2009-10-21 at 02:19 +0200, Jiri Palecek wrote:
>> Hello,
>>
>> this is another patch fixing bashisms in LTP tests (the fixes are more or less the same as in the previous patches, except for a few exceptions). Note that the patch is not complete, in the sense that there may remain further bashisms in the source even after applying the patch (like use of arrays, which is visible even from this patch).
>>
>> Regards
>>     Jiri Palecek
>>
>> Signed-off-by: Jiri Palecek <jpalecek@web.de>
>
> Hmm,. Some of them failed to apply. Can you please resend only the error
> part(s):

Sorry for not catching this sooner. netstat01 (and a lot of other
items under tcp_cmds) were rewritten to 1) remove bashisms, 2) make
the testing procedures more uniform, and 3) (the most important)
remove duplicate code in ipv6 and tcp_cmds.
Thanks,
-Garrett

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!