Re: [LTP] [PATCH] Fix some bashisms

Garrett Cooper
2009-07-07T16:26:22Z

On Tue, Jul 7, 2009 at 8:32 AM, Subrata Modak<subrata@linux.vnet.ibm.com> wrote:
> I can find that they addressed all issues of Mike and Matt. However, i
> would just wait for some more confirmation from them. Thanks.
>
> Regards--
> Subrata

Hi Jiri!
Your patch looks better than before, but like you mentioned in
your last reply, the:

command || RC=$?
if [ $RC -ne 0 ]; then

stuff is a bit inconsistent, and like you originally suggested it
should probably be more like:

command
if [ $? -ne 0 ]; then

It looks like it was inconsistent before anyhow to be honest, so
it shouldn't be a big problem, but if we can fix it, we probably
should. That's the only outstanding concern from my end.
Thanks!
-Garrett

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry