* Re: [LTP] FW: My first Patch
[not found] <E1MO8eL-0006Ot-8q@235xhf1.ch3.sourceforge.com>
@ 2009-07-07 14:26 ` Mike Frysinger
0 siblings, 0 replies; 4+ messages in thread
From: Mike Frysinger @ 2009-07-07 14:26 UTC (permalink / raw)
To: ltp-list; +Cc: Praveen, 'Naresh', 'Nathan Straz'
[-- Attachment #1.1: Type: text/plain, Size: 180 bytes --]
On Tuesday 07 July 2009 07:15:16 Praveen wrote:
> Please find my first 'file' command test patch attached with this email.
in the future, please use the unified diff format
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <200907071405.n67E5NwX022783@e6.ny.us.ibm.com>]
* Re: [LTP] FW: My first Patch
[not found] <200907071405.n67E5NwX022783@e6.ny.us.ibm.com>
@ 2009-07-07 15:32 ` Subrata Modak
2009-07-08 13:42 ` Praveen
0 siblings, 1 reply; 4+ messages in thread
From: Subrata Modak @ 2009-07-07 15:32 UTC (permalink / raw)
To: Praveen; +Cc: ltp-list, 'Nathan Straz', 'Naresh'
Praveen. Please use this:
diff -uprN
to generate your patches.
Regards--
Subrata
On Tue, 2009-07-07 at 16:45 +0530, Praveen wrote:
> Hi Subrata,
>
>
>
> Please find my first ‘file’ command test patch attached with this
> email.
>
>
>
> I have added detailed description of what individual test case does at
> the top
>
> of the test. Please feel free to review and provide me with your
> comments.
>
>
>
> The ‘file’ command test case in LTP test suite exists in path:
>
> “ltp-xxx/testcases/commands/ade/file/”
>
>
>
> Thanks,
>
> Praveen Kumar k
>
>
>
>
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] FW: My first Patch
2009-07-07 15:32 ` Subrata Modak
@ 2009-07-08 13:42 ` Praveen
0 siblings, 0 replies; 4+ messages in thread
From: Praveen @ 2009-07-08 13:42 UTC (permalink / raw)
To: subrata; +Cc: ltp-list, 'Nathan Straz', 'Naresh'
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
Hi,
Apologies for the inconvenience
Please find the patch attached with this email (Now "diff -uprN" is used to
generate the patch)
Thanks,
Praveen Kumar k
-----Original Message-----
From: Subrata Modak [mailto:subrata@linux.vnet.ibm.com]
Sent: Tuesday, July 07, 2009 9:03 PM
To: Praveen
Cc: ltp-list@lists.sourceforge.net; 'Naresh'; 'Nathan Straz'
Subject: Re: FW: My first Patch
Praveen. Please use this:
diff -uprN
to generate your patches.
Regards--
Subrata
On Tue, 2009-07-07 at 16:45 +0530, Praveen wrote:
> Hi Subrata,
>
>
>
> Please find my first 'file' command test patch attached with this
> email.
>
>
>
> I have added detailed description of what individual test case does at
> the top
>
> of the test. Please feel free to review and provide me with your
> comments.
>
>
>
> The 'file' command test case in LTP test suite exists in path:
>
> "ltp-xxx/testcases/commands/ade/file/"
>
>
>
> Thanks,
>
> Praveen Kumar k
>
>
>
>
[-- Attachment #2: file_test.patch --]
[-- Type: application/octet-stream, Size: 3870 bytes --]
--- file_test_old.sh 2009-07-07 14:15:51.000000000 +0530
+++ file_test.sh 2009-07-07 14:05:58.000000000 +0530
@@ -39,15 +39,97 @@
# accordingly.
-export TST_TOTAL=10 # Number of tests in this testcase
+#
+# Description of individual test cases
+# ------------------------------------
+#
+# Test01: Test if file command recognizes ASCII text files
+# -------
+# 1) Write text to a known file
+# 2) Use 'file' command to get the type of the known file
+# Ex: file xyz.txt
+# 3) Grep for the keyword "ASCII text" in the output of the
+# 'file' command
+# 4) Declare test as PASS if above step is successful else
+# declare test as FAIL
+#
+# Test02: Test if file command can recognize bash shell script
+# -------
+# 1) Write a small bash shell script to a known file
+# 2) Use 'file' command to get the type of the known file
+# Ex: file xyz.sh
+# 3) Grep for the keyword "Bourne-Again shell script" in
+# the output of the 'file' command
+# 4) Declare test as PASS if above step is successful else
+# declare test as FAIL
+#
+# Test03: Test if file command can recognize bash shell script
+# -------
+# Similar test(as Test02) is performed with Korn shell script
+#
+# Test04: Test if file command can recognize C shell script
+# -------
+# Similar test(as Test02) is performed with C shell script
+#
+# Test05: Test if file command can recognize C program text
+# -------
+# Similar test(as Test02) is performed with C program text
+#
+# Test06: Test if file command can recognize ELF binay executables
+# -------
+# 1) Grep for 'm68k' or 'sparc' or 'mips' or 'mipseb' or 'sh.eb'
+# or 'powerpc' or 'ppc' or 's390' from the output of the command
+# 'uname -m'
+# 2) If the above step is successful, assign string 'MSB' to variable
+# TARGET_ARCH else assign string 'LSB'
+# 3) Write small C program to a known '.c' file
+# 4) Compile it using "cc"
+# Ex: cc xyz xyz.c
+# 5) Use file command to get the type of the object file
+# 6) Grep for the string "ELF .*-bit $TEST_ARCH executable, .*"
+# in the output of the 'file' command
+# 7) If the above command is successful, declare test as PASS
+# else declare test as FAIL
+#
+# Test07: Test if file command can recognize tar files
+# -------
+# 1) Write text to three different files
+# 2) Archive the files using "tar" command
+# Ex: tar -cf ...
+# 3) Use 'file' command to get the type of the archive file
+# Ex: file xyz.tar
+# 4) Grep for the string "tar archive" from the output of
+# the above 'file' command
+# 5) Declare test as PASS, if the above step is successfull else
+# declare test as FAIL
+#
+# Test08: Test if file command can tar zip files
+# -------
+# 1) Write text to three different files
+# 2) Archive the files using "tar" command
+# Ex: tar -cf ...
+# 3) Use 'gzip' command to zip tar files
+# Ex: gzip -f xyz.tar
+# 4) Use 'file' command to get the type of the archive file
+# Ex: file xyz.tar.gz
+# 5) Grep for the string "gzip compressed data, .*" from the above
+# file commnand
+# 6) Declare test as PASS, if the above step is successfull else
+# declare test as FAIL
+#
+
+export TST_TOTAL=10 # Number of tests in this testcase
+
if [ -z "$LTPTMP" -a -z "$TMPBASE" ]
then
LTPTMP=/tmp/
else
- LTPTMP=$TMPBASE
+ LTPTMP=$TMPBASE
fi
+# 'LTPBIN' where actual test cases (test binaries) reside
+# 'LTPROOT' where the actual LTP test suite resides
if [ -z "$LTPBIN" -a -z "$LTPROOT" ]
then
LTPBIN=./
@@ -65,7 +147,7 @@ RC=0
# Test if file command recognizes ASCII text files.
export TCID=file01
-export TST_COUNT=7
+export TST_COUNT=1
$LTPBIN/tst_resm TINFO "TEST #1: file commad recogizes ASCII text files"
[-- Attachment #3: Type: text/plain, Size: 389 bytes --]
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] FW: My first Patch
@ 2009-07-07 11:15 Praveen
0 siblings, 0 replies; 4+ messages in thread
From: Praveen @ 2009-07-07 11:15 UTC (permalink / raw)
To: subrata; +Cc: ltp-list, 'Nathan Straz', 'Naresh'
[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]
Hi Subrata,
Please find my first 'file' command test patch attached with this email.
I have added detailed description of what individual test case does at the
top
of the test. Please feel free to review and provide me with your comments.
The 'file' command test case in LTP test suite exists in path:
"ltp-xxx/testcases/commands/ade/file/"
Thanks,
Praveen Kumar k
[-- Attachment #1.2: Type: text/html, Size: 5155 bytes --]
[-- Attachment #2: file_test.patch --]
[-- Type: application/octet-stream, Size: 4406 bytes --]
*** file_test_old.sh 2009-07-07 14:15:51.000000000 +0530
--- file_test.sh 2009-07-07 14:05:58.000000000 +0530
***************
*** 39,53 ****
# accordingly.
! export TST_TOTAL=10 # Number of tests in this testcase
if [ -z "$LTPTMP" -a -z "$TMPBASE" ]
then
LTPTMP=/tmp/
else
! LTPTMP=$TMPBASE
fi
if [ -z "$LTPBIN" -a -z "$LTPROOT" ]
then
LTPBIN=./
--- 39,135 ----
# accordingly.
! #
! # Description of individual test cases
! # ------------------------------------
! #
! # Test01: Test if file command recognizes ASCII text files
! # -------
! # 1) Write text to a known file
! # 2) Use 'file' command to get the type of the known file
! # Ex: file xyz.txt
! # 3) Grep for the keyword "ASCII text" in the output of the
! # 'file' command
! # 4) Declare test as PASS if above step is successful else
! # declare test as FAIL
! #
! # Test02: Test if file command can recognize bash shell script
! # -------
! # 1) Write a small bash shell script to a known file
! # 2) Use 'file' command to get the type of the known file
! # Ex: file xyz.sh
! # 3) Grep for the keyword "Bourne-Again shell script" in
! # the output of the 'file' command
! # 4) Declare test as PASS if above step is successful else
! # declare test as FAIL
! #
! # Test03: Test if file command can recognize bash shell script
! # -------
! # Similar test(as Test02) is performed with Korn shell script
! #
! # Test04: Test if file command can recognize C shell script
! # -------
! # Similar test(as Test02) is performed with C shell script
! #
! # Test05: Test if file command can recognize C program text
! # -------
! # Similar test(as Test02) is performed with C program text
! #
! # Test06: Test if file command can recognize ELF binay executables
! # -------
! # 1) Grep for 'm68k' or 'sparc' or 'mips' or 'mipseb' or 'sh.eb'
! # or 'powerpc' or 'ppc' or 's390' from the output of the command
! # 'uname -m'
! # 2) If the above step is successful, assign string 'MSB' to variable
! # TARGET_ARCH else assign string 'LSB'
! # 3) Write small C program to a known '.c' file
! # 4) Compile it using "cc"
! # Ex: cc xyz xyz.c
! # 5) Use file command to get the type of the object file
! # 6) Grep for the string "ELF .*-bit $TEST_ARCH executable, .*"
! # in the output of the 'file' command
! # 7) If the above command is successful, declare test as PASS
! # else declare test as FAIL
! #
! # Test07: Test if file command can recognize tar files
! # -------
! # 1) Write text to three different files
! # 2) Archive the files using "tar" command
! # Ex: tar -cf ...
! # 3) Use 'file' command to get the type of the archive file
! # Ex: file xyz.tar
! # 4) Grep for the string "tar archive" from the output of
! # the above 'file' command
! # 5) Declare test as PASS, if the above step is successfull else
! # declare test as FAIL
! #
! # Test08: Test if file command can tar zip files
! # -------
! # 1) Write text to three different files
! # 2) Archive the files using "tar" command
! # Ex: tar -cf ...
! # 3) Use 'gzip' command to zip tar files
! # Ex: gzip -f xyz.tar
! # 4) Use 'file' command to get the type of the archive file
! # Ex: file xyz.tar.gz
! # 5) Grep for the string "gzip compressed data, .*" from the above
! # file commnand
! # 6) Declare test as PASS, if the above step is successfull else
! # declare test as FAIL
! #
+
+ export TST_TOTAL=10 # Number of tests in this testcase
+
if [ -z "$LTPTMP" -a -z "$TMPBASE" ]
then
LTPTMP=/tmp/
else
! LTPTMP=$TMPBASE
fi
+ # 'LTPBIN' where actual test cases (test binaries) reside
+ # 'LTPROOT' where the actual LTP test suite resides
if [ -z "$LTPBIN" -a -z "$LTPROOT" ]
then
LTPBIN=./
***************
*** 65,71 ****
# Test if file command recognizes ASCII text files.
export TCID=file01
! export TST_COUNT=7
$LTPBIN/tst_resm TINFO "TEST #1: file commad recogizes ASCII text files"
--- 147,153 ----
# Test if file command recognizes ASCII text files.
export TCID=file01
! export TST_COUNT=1
$LTPBIN/tst_resm TINFO "TEST #1: file commad recogizes ASCII text files"
[-- Attachment #3: Type: text/plain, Size: 390 bytes --]
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/blackberry
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-08 14:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1MO8eL-0006Ot-8q@235xhf1.ch3.sourceforge.com>
2009-07-07 14:26 ` [LTP] FW: My first Patch Mike Frysinger
[not found] <200907071405.n67E5NwX022783@e6.ny.us.ibm.com>
2009-07-07 15:32 ` Subrata Modak
2009-07-08 13:42 ` Praveen
2009-07-07 11:15 Praveen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox