Re: [LTP] [PATCH 2/3] Make system enhancements, Draft 1

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1688 bytes --]

On Monday 06 July 2009 19:02:50 Garrett Cooper wrote:
> 1. Write up a document on how to use the new Make system
> (README.mk-devel), so others may assist in the work that we're
> spearheading at Cisco and contributing back to LTP, and we can begin
> dropping the adhoc Makefiles.
> 2. Add master_rules.mk which contains canned rules for environment
> setup, leaf directories, and trunk directories to reduce Make logic
> noise in the existing LTP Makefile's. This is a more condensed and
> straightforward version of the original master_rules.mk file
> contributed and never integrated into LTP in the past.
> 3. Add master_include.mk, a file which stands as the defacto include
> Makefile for all . This was created out of the comment provided by
> Mike Frysinger w.r.t. a master include file.
>
> Note: This patch has been largely tested, but some of the additional
> functionality and rework in generic_trunk_target needs to be tested
> more prior to commit; hence it's a Draft 1 patch.

"srcdir" should refer to the current directory's source tree.  "top_srcdir" 
should refer to the top level source tree.  building in-tree means srcdir will 
be ".".  this is how autotools works and allows for easy out-of-tree 
compilation.  same goes for "builddir" and "top_builddir", not this "objxxx" 
convention.

for the toolchain, do you purposefully only document CC and CFLAGS ?

i'm not familiar with this "MAKEOPTS=';'" thing you refer to.  what's that all 
about ?

you list the copyright info twice

master_rules.mk shouldnt be a '-include' ... we want an error if that doesnt 
exist

your %.a rule is missing a call to ranlib on the archive
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 389 bytes --]

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list