From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by 235xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MQjGf-0002xr-PU for ltp-list@lists.sourceforge.net; Tue, 14 Jul 2009 14:46:05 +0000 Received: from moutng.kundenserver.de ([212.227.17.10]) by 29vjzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1MQjGZ-0004m2-JY for ltp-list@lists.sourceforge.net; Tue, 14 Jul 2009 14:46:05 +0000 From: Arnd Bergmann Date: Tue, 14 Jul 2009 16:45:48 +0200 References: <4A5C8068.6020203@monstr.eu> <200907141521.47719.arnd@arndb.de> <4A5C8BF2.8020505@monstr.eu> In-Reply-To: <4A5C8BF2.8020505@monstr.eu> MIME-Version: 1.0 Message-Id: <200907141645.48833.arnd@arndb.de> Subject: Re: [LTP] access_ok macor List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: monstr@monstr.eu Cc: LTP , Linux Kernel list On Tuesday 14 July 2009, Michal Simek wrote: > Arnd Bergmann wrote: > Look at > http://developer.petalogix.com/git/gitweb.cgi?p=ltp-microblaze.git;a=commitdiff;h=45f4cd783ce8b94f1267bb87c0c46e8536f62eca > > There are three affected tests and my quick fixes which I am trying to solve now. > ok, I see. > int move_addr_to_user(struct sockaddr *kaddr, int klen, void __user *uaddr, > int __user *ulen) > { > int err; > int len; > > err = get_user(len, ulen); > if (err) > return err; > So the code looks something like "1: lw %1, %2, r0; \ addk %0, r0, r0; \ 2: \ .section .fixup,\"ax\"; \ 3: brid 2b; \ addik %0, r0, %3; \ .previous; \ .section ,\"a\"; \ .word 1b,3b; \ .previous;" \ Not much that can go wrong there. First of all, I'd check that the code actually looks the same in the binary. I assume that the 'addik' gets executed when the brid branches, right? I would guess that some of the logic in do_page_fault might be broken and does not actually call the fixup. Arnd <>< ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list