public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] Fix digsig so it passes -Wshadow
Date: Fri, 31 Jul 2009 09:35:44 -0500	[thread overview]
Message-ID: <20090731143544.GA9440@us.ibm.com> (raw)
In-Reply-To: <364299f40907302333s61742580m5dba94b0a2e7afa5@mail.gmail.com>

Quoting Garrett Cooper (yanegomi@gmail.com):
> clone(2) is externally defined in sched.h, and as such
> testcases/kernel/security/digsig/writeexec/libwritetest.c fails to
> compile with -Wall due to a shadowed declaration.
> 
> Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
> 
> Index: writeexec/libwritetest.c
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/security/digsig/writeexec/libwritetest.c,v
> retrieving revision 1.1
> diff -u -r1.1 libwritetest.c
> --- writeexec/libwritetest.c	1 Nov 2005 16:09:43 -0000	1.1
> +++ writeexec/libwritetest.c	31 Jul 2009 06:30:49 -0000
> @@ -9,8 +9,6 @@
>  #include <dlfcn.h>
>  #include <wait.h>
> 
> -int clone(int (*fn)(void *), void *child_stack, int flags, void *arg);
> -
>  int writer(void *data)
>  {
>  	int fd;

Sure, as long as that's now the case on all distros.  Historically it
hasn't been.  But if it's not we'll presumably hear about it.

-serge

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2009-07-31 14:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31  6:33 [LTP] Fix digsig so it passes -Wshadow Garrett Cooper
2009-07-31  7:43 ` Garrett Cooper
2009-07-31 14:36   ` Serge E. Hallyn
2009-08-03 11:20     ` Subrata Modak
2009-08-03 14:17       ` Serge E. Hallyn
2009-08-04 12:08         ` Subrata Modak
2009-07-31 14:35 ` Serge E. Hallyn [this message]
2009-08-13  7:24   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090731143544.GA9440@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox