From: Cyril Hrubis <chrubis@suse.cz>
To: Michal Simek <michal.simek@petalogix.com>
Cc: ltp-list@lists.sourceforge.net, Jyoti <jyotiv@linux.vnet.ibm.com>
Subject: Re: [LTP] Submitting patch
Date: Mon, 3 Aug 2009 15:54:51 +0200 [thread overview]
Message-ID: <20090803135451.GA11225@schrodinger.suse.cz> (raw)
In-Reply-To: <4A76EA47.7070209@petalogix.com>
Hi!
> > What's wrong with linux kernel coding style? Most of the decent text editors
> > that are used these days (vim, emacs...) just helps format code like this. (Eg.
> > default intendation is done by tabs and so on...) I don't like the idea
> > changing tabs to spaces before sending a patch.
>
> There is only one thing which is IMHO not good - it is 80 char line size.
> I would prefer longer lines (maybe 120 chars).
> This is for C code not for any other.
> Are you ok with it?
Well, I'm not happy with very long lines, but there are indeed circumstances
where long lines are best solution.
So may be this should be strong recomendation rather than rule.
> P.S.: Cyril: Are you from Czech?
Sure.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-08-03 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 11:00 [LTP] Submitting patch jyotiv
2009-07-25 6:15 ` Michal Simek
2009-07-25 16:48 ` Garrett Cooper
2009-07-27 9:29 ` Michal Simek
2009-07-30 18:29 ` Subrata Modak
2009-08-03 10:47 ` Cyril Hrubis
[not found] ` <4A76EA47.7070209@petalogix.com>
2009-08-03 13:54 ` Cyril Hrubis [this message]
[not found] ` <4A76F856.6030307@petalogix.com>
[not found] ` <364299f40908030944n74d79509r716dcbcc8875677b@mail.gmail.com>
[not found] ` <4A77F359.40901@petalogix.com>
2009-08-04 10:11 ` Subrata Modak
2009-07-30 18:50 ` Garrett Cooper
-- strict thread matches above, loose matches on Subject: below --
2009-08-05 9:00 Jyoti
2009-08-05 9:10 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803135451.GA11225@schrodinger.suse.cz \
--to=chrubis@suse.cz \
--cc=jyotiv@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox