public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Michal Simek <michal.simek@petalogix.com>
Cc: LTP <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] clone01 -c 10 on x86
Date: Tue, 4 Aug 2009 12:32:19 -0500	[thread overview]
Message-ID: <20090804173219.GB3698@us.ibm.com> (raw)
In-Reply-To: <4A785468.6020803@petalogix.com>

Quoting Michal Simek (michal.simek@petalogix.com):
> Subrata Modak wrote:
> > On Mon, 2009-08-03 at 10:14 -0500, Serge E. Hallyn wrote: 
> >   
> >> Quoting Michal Simek (michal.simek@petalogix.com):
> >>     
> >>> Hi All,
> >>>
> >>> can you please to run clone01 syscall test on any x86 machine? I am
> >>> getting fault there when I run it 10 times for example.
> >>> The same problem I have on Microblaze.
> >>>
> >>>  ./clone01  -c 10
> >>> clone01     1  TPASS  :  clone() returned 22738
> >>> clone01     1  TPASS  :  clone() returned 22740
> >>> clone01     1  TPASS  :  clone() returned 22742
> >>> clone01     1  TPASS  :  clone() returned 22748
> >>> clone01     1  TPASS  :  clone() returned 22750
> >>> clone01     1  TPASS  :  clone() returned 22752
> >>> clone01     1  TPASS  :  clone() returned 22754
> >>> clone01     1  TFAIL  :  clone() returned 134919589, errno = 22755
> >>> [monstr@monstr clone]$ clone01     1  TPASS  :  clone() returned 22744
> >>> clone01     1  TPASS  :  clone() returned 22746
> >>>
> >>> Thanks,
> >>> Michal
> >>>       
> >> All right I don't have the patiente to wade through the parse_opts
> >> and usc_lib crap, but this is not a clone failure.  What appears to
> >> be happening is setup() at the top of clone01.c is calling
> >> lib/parse_opts.c:usc_global_setup_hook(), with STD_COPIES set to the
> >> count option you passed in.  That forks of 10 copies of the test.
> >> I don't know what happens with the actual loop then, but the reason
> >> you get the error for the last clone test is that one of those
> >> forked copies of clone01 (*not* one of the cloned children) exits,
> >> and wait() catches that one.  That is why wait() returned 22744,
> >> which isn't any of the cloned children.
> >>
> >> So one stupid way of fixing this without dealing with the convoluted
> >> setup junk would be to change the waitpid chunk of the code like so:
> >>     
> >
> > Yes, it fixes the issue.
> >   
> Yes, but as Serge wrote above his patch just cover different fault not
> solve it.

Although that depends on what we think the fault really is.  The reason
we were getting fail messages was that children were exiting which we
were (wrongly) not expecting.  Now, I don't understand why setup()
forks off N tasks, and it would probably be best to not do that.  But
in the end so long as we ignore when those tasks are reaped, it really
doesn't matter that there were extra children.  We are testing that clone(2)
succeeded now, which is what we really care about.

-serge

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-08-04 17:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 12:23 [LTP] clone01 -c 10 on x86 Michal Simek
2009-08-03 15:14 ` Serge E. Hallyn
2009-08-04 12:08   ` Subrata Modak
2009-08-04 15:31     ` Michal Simek
2009-08-04 17:32       ` Serge E. Hallyn [this message]
2009-08-13  7:53   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090804173219.GB3698@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=michal.simek@petalogix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox