Re: [LTP] [PATCH 05/05] Add the necessary Interface and Option through "runltp"

Paul Larson
2009-08-11T18:02:26Z

Subrata Modak wrote:
...
> + -F LOOPS,PERCENTAGE Induce PERCENTAGE Fault in the Kernel Subsystems, and, run each test for LOOPS loop

I haven't had time for an exhaustive review, but here are a few
questions/comments I had:

1. Why introduce yet another looping mechanism within LTP when we
already have one? Is there an advantage that you see to doing it this
way, rather than just having an additional option that calls the script
to generate this additional random fault injection?

2. Would be good to push the check for /debug being mounted down into
one of the other scripts rather than in runltp. runltp is already
hideously bloated and this would make it more useful when running
standalone.

3. would be great if there were some way to tag the results to say when
a fault was or was not in the process of being generated. That is,
perhaps, not possible at this time though.

4. more granularity possible with the fault injections to specify the
type of faults, or optionally, the behaviour you have here?

Thanks,
Paul Larson