Re: [LTP] Fix digsig so it passes -Wshadow

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]

On Friday 31 July 2009 10:35:44 Serge E. Hallyn wrote:
> Quoting Garrett Cooper (yanegomi@gmail.com):
> > clone(2) is externally defined in sched.h, and as such
> > testcases/kernel/security/digsig/writeexec/libwritetest.c fails to
> > compile with -Wall due to a shadowed declaration.
> >
> > Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
> >
> > --- writeexec/libwritetest.c	1 Nov 2005 16:09:43 -0000	1.1
> > +++ writeexec/libwritetest.c	31 Jul 2009 06:30:49 -0000
> > @@ -9,8 +9,6 @@
> >  #include <dlfcn.h>
> >  #include <wait.h>
> >
> > -int clone(int (*fn)(void *), void *child_stack, int flags, void *arg);
> > -
> >  int writer(void *data)
> >  {
> >  	int fd;
>
> Sure, as long as that's now the case on all distros.  Historically it
> hasn't been.  But if it's not we'll presumably hear about it.

except clone() is not safe to use directly as it isnt the same on all arches.  
we really need a wrapper for this in ltp.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list