Re: [LTP] The Best Practice to Skip Syscall Tests

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1829 bytes --]

On Saturday 22 August 2009 22:37:28 CAI Qian wrote:
> From: Garrett Cooper <yanegomi@gmail.com>
> > On Fri, Aug 21, 2009 at 9:00 AM, Mike Frysinger wrote:
> >> On Friday 21 August 2009 07:57:39 CAI Qian wrote:
> >>> Test cases unshare failed to compile on systems without such a
> >>> syscall. I am unsure what the best way to handle it. The old ways are,
> >>>
> >>> * add a kernel version check in the unshare tests code.
> >>>
> >>> or
> >>>
> >>> * add a m4 rule.
> >>> * modify the unshare tests code to check if the macro, and add stub
> >>>   functions if the macro is false.
> >>>
> >>> The first approach is unable to handle non-vanilla kernels. The second
> >>> approach needs to add stub functions which are unclean. What I would
> >>> like to do is,
> >>>
> >>> * add a m4 rule.
> >>> * modify unshare Makefile like this,
> >>>
> >>>   ifdef HAVE_UNSHARE  <-- if the syscall is present, compile the tests.
> >>
> >> the configure test should always be there if the code needs new headers
> >> (like sys/signalfd.h).  if it's only a new syscall, then the configure
> >> test should only be for the new symbol (assuming one is provided).  in
> >> all cases, the tests should be compiled.  your proposal doesnt handle
> >> the case where the C library is in place, but the kernel is older so
> >> returns ENOSYS.
> >
> >     check_for_unshare was a poorly hacked app, IMO and Mike is
> > correct. The issue needs to be a combination of buildtime and runtime
> > tests as it needs to pass through the build and the issue with the
> > syscall needs to be detected and marked TBROK if the syscall isn't
> > implemented.
>
> ENOSYS is the expected result if the kernel under test has no such
> implementation, so I would consider TPASS or TCONF.

TPASS is wrong.  in another thread, people seemed to be OK with TCONF.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list