Re: [LTP] [PATCH 2/3] Fix unshare01

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 615 bytes --]

On Monday 24 August 2009 00:05:59 CAI Qian wrote:
> +#ifdef HAVE_UNSHARE
> +#include "linux_syscall_numbers.h"

this doesnt make sense.  if the C library has unshare(), then there is no 
point in including the syscall numbers nor using syscall() because you can use 
the C libraries' unshare().

> +				tst_resm(TFAIL, "fork() Failed, errno=%d : %s",
> +					TEST_ERRNO, strerror(TEST_ERRNO));

this (and just about every other line you changed) should be using the TTERRNO 
flag rather than parsing TEST_ERRNO yourself.  so this line would simply be:
tst_resm(TFAIL|TTERRNO, "fork() failed");
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list