[LTP] [PATCH 1/1] netns: don't run sysfsview testcase

[LTP] [PATCH 1/1] netns: don't run sysfsview testcase

[Serge E. Hallyn]

It can't pass right now, and leaves the system in a bad state on
its inevitable failure.

Leave the testcase there though since one day we will hopefully
support it.

Signed-off-by: Serge Hallyn <serge@us.ibm.com>
---
 testcases/kernel/containers/netns/runnetnstest.sh |   25 ++++++++++++--------
 1 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/testcases/kernel/containers/netns/runnetnstest.sh b/testcases/kernel/containers/netns/runnetnstest.sh
index 8a52e7b..e5ae694 100755
--- a/testcases/kernel/containers/netns/runnetnstest.sh
+++ b/testcases/kernel/containers/netns/runnetnstest.sh
@@ -90,16 +90,21 @@ else
 fi
 echo
 
-sysfsview
-rc=$?
-if [ $rc -ne 0 ]; then
-    exit_code=$rc
-    errmesg="$errmesg sysfsview: return code is $exit_code ; "
-    echo $errmesg
-else
-   echo "sysfsview: PASS"
-fi
-echo
+# sysfs tagging does not exist, so this test can't pass.  In
+# fact at the moment it fails when mount -t sysfs none /sys is
+# refused, fails in a bad state, leaving the system hard to
+# reboot.  Revisit enabling this test when per-container sysfs
+# views are supported.
+#sysfsview
+#rc=$?
+#if [ $rc -ne 0 ]; then
+#    exit_code=$rc
+#    errmesg="$errmesg sysfsview: return code is $exit_code ; "
+#    echo $errmesg
+#else
+#   echo "sysfsview: PASS"
+#fi
+#echo
 
 par_chld_ftp
 rc=$?
-- 
1.6.0.4


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 1/1] netns: don't run sysfsview testcase

[Subrata Modak]

On Wed, 2009-08-26 at 00:57 -0500, Serge E. Hallyn wrote:
> It can't pass right now, and leaves the system in a bad state on
> its inevitable failure.
> 
> Leave the testcase there though since one day we will hopefully
> support it.
> 
> Signed-off-by: Serge Hallyn <serge@us.ibm.com>

Ok. Merged.

Regards--
Subrata

> ---
>  testcases/kernel/containers/netns/runnetnstest.sh |   25 ++++++++++++--------
>  1 files changed, 15 insertions(+), 10 deletions(-)
> 
> diff --git a/testcases/kernel/containers/netns/runnetnstest.sh b/testcases/kernel/containers/netns/runnetnstest.sh
> index 8a52e7b..e5ae694 100755
> --- a/testcases/kernel/containers/netns/runnetnstest.sh
> +++ b/testcases/kernel/containers/netns/runnetnstest.sh
> @@ -90,16 +90,21 @@ else
>  fi
>  echo
> 
> -sysfsview
> -rc=$?
> -if [ $rc -ne 0 ]; then
> -    exit_code=$rc
> -    errmesg="$errmesg sysfsview: return code is $exit_code ; "
> -    echo $errmesg
> -else
> -   echo "sysfsview: PASS"
> -fi
> -echo
> +# sysfs tagging does not exist, so this test can't pass.  In
> +# fact at the moment it fails when mount -t sysfs none /sys is
> +# refused, fails in a bad state, leaving the system hard to
> +# reboot.  Revisit enabling this test when per-container sysfs
> +# views are supported.
> +#sysfsview
> +#rc=$?
> +#if [ $rc -ne 0 ]; then
> +#    exit_code=$rc
> +#    errmesg="$errmesg sysfsview: return code is $exit_code ; "
> +#    echo $errmesg
> +#else
> +#   echo "sysfsview: PASS"
> +#fi
> +#echo
> 
>  par_chld_ftp
>  rc=$?


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list