Re: [LTP] [PATCH] Add autoconf tests for taskstats members not present?on older kernels

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > > this patch adds autoconf checks for some build failures reported by Cyril
> > > Hrubis. Please note I have not tested this on an old kernel.
> > >
> > > Also, it corrects the names of the preprocessor macros defined by
> > > autoconf
> > >
> > > The remaining issue (the cgroupstats.h file) should be solved using the
> > > autoconf test that was committed recently.
> >
> > The autoconf part is okay, but getdelays.c needs some more #ifdef
> > HAVE_LINUX_CGROUPSTAT_H to build correctly on all I have here.
> >
> > Patch attached, however it may need minor cleanups.
> 
> preprocessor macros should never be intended

I allways forgot this one...

> can the test case pass at all if the linux headers are missing ?  if they 
> cant, there's no point in sprinkling #ifdef's throughout the code.  stub the 
> whole thing out.

As far as I see the cgroupstat code is activated only by -C switch, so it does
make sence spread #ifdefs around.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list