Re: [LTP] [PATCH 16/21] Add sigreturn01 test for sigreturn syscall

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
This test doesn't compile cleanly because on all linuxes I've try to do so
sigreturn() is not defined as manual says.

Instead of:

sigreturn(unsigned long __unused);

It's defined as:

extern int sigreturn (struct sigcontext *__scp) __THROW;

And it also seems to be unimplemented on linux.

Anyway after looking into the source and manual, the test seems to be testing
return value of call that does some magic on the stack of the process in order
to return from signal handler. And the "never return" in manual means IMHO that
execution path of the program is changed in a way the return value of sigreturn
can't be checked at all. To me it looks like some old and unused internal
kernel/glibc api that is not worth testing. So I vote for removing this one
from ltp.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list