public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>,
	Ashwin Ganti <ashwin.ganti@gmail.com>
Subject: Re: [LTP] [LTP PATCH] Create testcase for p9auth kernel module
Date: Mon, 21 Sep 2009 00:26:47 -0500	[thread overview]
Message-ID: <20090921052647.GA32556@us.ibm.com> (raw)
In-Reply-To: <1253449605.7736.7.camel@subratamodak.linux.ibm.com>

Quoting Subrata Modak (subrata@linux.vnet.ibm.com):
> On Wed, 2009-09-16 at 16:28 -0500, Serge E. Hallyn wrote:
> > The p9auth module is a driver in the staging/ directory, which
> > implements kernel functionality supporting plan 9-style setuid.
> > Programs can be completely unprivileged, authorize themselves
> > to a privileged server, and obtain a token which they can use to
> > authorize a single setuid to a single specified new uid.
> > 
> > This testcase runs three tests:
> > 	1. make sure we can't setuid without a hash
> > 		(this is actually short-cut in the kernel code
> > 		so it might be worthwhile having a separate
> > 		test for having a hash, but an invalid one)
> > 	2. make sure we can setuid when there is a valid hash
> > 	3. make sure we cannot setuid if there is a valid hash,
> > 		but our original uid isn't the one specified
> > 		in the token.
> > 
> > Run the testcase using
> > 
> > 	./runltp -f p9auth
> > 
> > Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
> 
> Thanks Serge. The patch seems to be fine except that the following
> script:
> 
> 		runp9auth.sh
> 
> make[4]: Entering directory
> `/root/subrata/ltp/ltp-full-20090831/testcases/kernel/security/p9auth'
> make[4]: *** No rule to make target `runp9auth.sh', needed by `install'.
> Stop.
> make[4]: Leaving directory
> `/root/subrata/ltp/ltp-full-20090831/testcases/kernel/security/p9auth'
> make[3]: *** [install] Error 2
> make[3]: Leaving directory
> `/root/subrata/ltp/ltp-full-20090831/testcases/kernel/security'
> make[2]: *** [install] Error 2
> make[2]: Leaving directory
> `/root/subrata/ltp/ltp-full-20090831/testcases/kernel'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory
> `/root/subrata/ltp/ltp-full-20090831/testcases'
> make: *** [install] Error 2

Oops.

> is missing from the patch. So, i was not able to test this. Can you
> please fix this and resend again. In your new patch, can you also
> include mentioning the following .config file options for enabling
> PLAN9AUTH in kernel, through ltp/README:
> 
> CONFIG_CRYPTO=y
> CONFIG_STAGING=y
> # CONFIG_STAGING_EXCLUDE_BUILD is not set
> CONFIG_PLAN9AUTH=m

After I sent it I remembered I didn't address the TODO about
checking for openssl and figured i'd get yelled at for that :)

I'll fix those up and resend when I can.

thanks,
-serge

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-09-21  5:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 21:28 [LTP] [LTP PATCH] Create testcase for p9auth kernel module Serge E. Hallyn
2009-09-20 12:26 ` Subrata Modak
2009-09-21  5:26   ` Serge E. Hallyn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-09-20 12:43 Subrata Modak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090921052647.GA32556@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=ashwin.ganti@gmail.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=subrata@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox