Re: [LTP] [PATCH 1/1] define and use common clone helpers (v2)

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1173 bytes --]

On Tuesday 29 September 2009 19:30:15 Serge E. Hallyn wrote:
> Define ltp_clone() and ltp_clone_malloc() in libltp, and convert existing
> clone usages to them.  (clone04 can't use it bc it wants to pass NULL,
> which ltp_clone() will for many arches convert to NULL+stacksize-1).

i thought you fixed the clone04 issue ?

> +int ltp_clone(unsigned long clone_flags, int (*fn)(void *arg), void *arg,
> +		int stack_size, void *stack);

change stack_size to size_t to match malloc()

> +/* int  __clone2(int (*fn) (void *arg), void *child_stack_base,		*/
> +/* 		size_t child_stack_size, int flags, void *arg,		*/
> +/*		pid_t *parent_tid, void *tls, pid_t *child_tid)		*/
> +extern int  __clone2(int (*fn) (void *arg), void *child_stack_base,
> +		size_t child_stack_size, int flags, void *arg,
> +		pid_t *parent_tid, void *tls, pid_t *child_tid);

what's with the big commented prototype ?  just scrub it ...

> + *   1. hppa takes bottom of stack and no stacksize

note that it's because their stack grows up

> + *   3. all others take top of stack,

note that it's because their stack grows down

otherwise, all the changes look straight forward.  thanks again.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 401 bytes --]

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list