public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Subrata Modak1 <subrata.modak@in.ibm.com>
Cc: LTP list <ltp-list@lists.sourceforge.net>
Subject: [LTP] [PATCH 1/1] p9auth: fix a bug in the p9auth setup script
Date: Thu, 8 Oct 2009 11:59:29 -0500	[thread overview]
Message-ID: <20091008165929.GA27576@us.ibm.com> (raw)

If by chance /dev/caphash existed but /dev/capuse did not, then
the checkp9auth.sh script would use $maj without setting it.

Signed-off-by: Serge Hallyn <serue@us.ibm.com>
---
 testcases/kernel/security/p9auth/checkp9auth.sh |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/security/p9auth/checkp9auth.sh b/testcases/kernel/security/p9auth/checkp9auth.sh
index 4365427..4a5a7d4 100755
--- a/testcases/kernel/security/p9auth/checkp9auth.sh
+++ b/testcases/kernel/security/p9auth/checkp9auth.sh
@@ -47,7 +47,6 @@ if [ $? -ne 0 ]; then
 fi
 
 majfile=/sys/module/p9auth/parameters/cap_major
-minfile=/sys/module/p9auth/parameters/cap_minor
 if [ ! -f "$majfile" ]; then
 	if [ $yesno -eq 1 ]; then echo
 		echo "no"
@@ -56,16 +55,15 @@ if [ ! -f "$majfile" ]; then
 	fi
 	exit 1
 fi
+maj=`cat $majfile`
 
 if [ ! -c "/dev/caphash" ]; then
 	rm -f /dev/caphash
-	maj=`cat $majfile`
 	mknod /dev/caphash c $maj 0
 fi
 
 if [ ! -c "/dev/capuse" ]; then
 	rm -f /dev/capuse
-	min=`cat $minfile`
 	mknod /dev/capuse c $maj 1
 fi
 chmod ugo+w /dev/capuse
-- 
1.6.3.3


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2009-10-08 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 16:59 Serge E. Hallyn [this message]
2009-10-13 14:43 ` [LTP] [PATCH 1/1] p9auth: fix a bug in the p9auth setup script Subrata Modak
2009-10-13 19:18   ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091008165929.GA27576@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=subrata.modak@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox